Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [bot]s from results #37

Open
1 task
paulodiovani opened this issue Oct 23, 2019 · 4 comments
Open
1 task

Remove [bot]s from results #37

paulodiovani opened this issue Oct 23, 2019 · 4 comments
Labels

Comments

@paulodiovani
Copy link
Owner

We don't want to list bots in the rank, which usually create auto pull requests to upgrade forks from upstream branches or from repositories outside github.

  • Filter out any username that has a [bot] suffix
    The easiest way is to just add a .filter to the results we get from redis.

    Alternatively, we could filter when fetching from github and not save on redis at all. For this option, check if github search api allows to exclude bots from results or to add an exclude filter for the search.

@lldh
Copy link
Contributor

lldh commented Oct 23, 2019

Hi, Can I grab this one? Thanks!

@paulodiovani
Copy link
Owner Author

Sure. :)

@paulodiovani paulodiovani added this to the Challenge's End milestone Oct 24, 2019
@paulodiovani
Copy link
Owner Author

paulodiovani commented Oct 31, 2019

Reopened.
We also need to remove names that ends with -bot. Actually, may anything ending with bot

@paulodiovani paulodiovani reopened this Oct 31, 2019
@paulodiovani paulodiovani added the good first issue Good for newcomers label Nov 8, 2019
@paulodiovani
Copy link
Owner Author

It seems there are also some bots with the name starting with bot or even in the middle.
May we should create a blacklist stored in redis or something similar to filter out the bots.

Suggestions on the approach are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants