-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch only when payload-token is set #2
Comments
Code snippet for Next.js SSR:
This completely removes the admin bar for non-Payload users. |
Thanks for this @cbratschi Does this mean that you load the AdminBar in a server component? So without using 'use client'? |
@notflip we implemented our own admin bar and just switched to the local API (payload.auth()) instead of using the cookies. It is mostly server rendered, menus are client components in our case. |
@cbratschi That's what I've been working on yesterday as well, using a combo of server and client
One thing that bothers me, and it's also the case in the website template from Payload, is that you also see the admin bar when you use "live preview" in a collection, how do you deal with that? |
@notflip thanks for mentioning this. We also render the admin bar in previews. We use a separate route for the previews and pass a preview property to the rendering component. Put it on our to do list 👍 |
This is not really an issue but a proposal for a performance improvement. The component is initially fetching "me" to detect if a user is logged in. For regular visitors this increases the initial load even though they are not editors. In my own project I used a wrapper for the AdminBar to check if the payload-token HttpOnly Cookies is set. If so I render the admin bar which fetches "me". I could open a PR with this approach applied if someone else finds this useful.
The text was updated successfully, but these errors were encountered: