fix(ui): prevents fieldSelect from showing invalid fields in editMany #10132
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aims to fix two issues with the bulk edit flow. First, prevent the selection of invalid fields in the
FieldSelect
component. Second, prevent a runtime error when bulk editting docs in fields that have not defined anadmin
property.Why?
For a more straightforward experience while bulk editing documents which have, potentially, several non-editable fields. Also, to prevent a runtime error.
How?
By taking into account that
admin
may not always be provided in thereduceFields
function, and including checks foradmin.hidden
(which is distinct fromhidden
) andadmin.readonly
.Fixes #10131
Before:
Media-bulkedit-before--Payload.webm
After:
Media-bulkedit-after--Payload.webm
Notes:
readOnly
set, where sometimes the value is not populated in those fields in theEditMany
drawer. This also reverts rows, or adds strange messages to row fields inarray
fields withreadOnly
members.fieldIsHiddenOrDisabled
function in thepayload
package as that behavior seems distinct from checking againstadmin.readOnly
sinceadmin.hidden
does not imply that it should be hidden from API calls.