Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploads with "%" in filename fail to show (s3Adapter) #6985

Open
carstenblt opened this issue Jun 29, 2024 · 2 comments · May be fixed by #6990
Open

Uploads with "%" in filename fail to show (s3Adapter) #6985

carstenblt opened this issue Jun 29, 2024 · 2 comments · May be fixed by #6990
Labels
status: needs-triage Possible bug which hasn't been reproduced yet v2

Comments

@carstenblt
Copy link

Link to reproduction

No response

Describe the Bug

When uploading a file like "test%test.jpg", it can't be viewed, because the URL is not encoded.

This could be solved by using encodeURIComponent on the filename.

To Reproduce

  • Upload file that contains a %-character in the filename
  • try to view the file. Both thumbnail and download fail

Payload Version

2.22.2

Adapters and Plugins

payload-cloud-storage, s3Adapter
@carstenblt carstenblt added status: needs-triage Possible bug which hasn't been reproduced yet v2 labels Jun 29, 2024
@rafalnawojczyk rafalnawojczyk linked a pull request Jun 30, 2024 that will close this issue
Open
11 tasks
@rafalnawojczyk
Copy link
Contributor

I've came across the same issue in my codebase. Already created a PR that resolved this problem on my end.

@smoothdvd
Copy link

Same as local storage. The filename saved in ascii code.
Screenshot 2024-07-04 at 10 40 41 PM
The original filename is in Chinese: 橙柿App文章202406.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs-triage Possible bug which hasn't been reproduced yet v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-cloud-storage): encode filename to remove unsupported chars rafalnawojczyk/payload
3 participants
@smoothdvd @carstenblt @rafalnawojczyk