From bd9c0b7ecc730b00bed8f9a6c0a5a297679997f5 Mon Sep 17 00:00:00 2001 From: "Merlin (they/them)" <124289716+merlinpaypal@users.noreply.github.com> Date: Fri, 12 Apr 2024 09:21:18 -0400 Subject: [PATCH] Change to MODAL_VIEWED --- library/src/main/java/com/paypal/messages/ModalFragment.kt | 2 +- .../src/main/java/com/paypal/messages/analytics/EventType.kt | 2 +- .../test/java/com/paypal/messages/analytics/EventTypeTest.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/library/src/main/java/com/paypal/messages/ModalFragment.kt b/library/src/main/java/com/paypal/messages/ModalFragment.kt index dbeb560..664a1f5 100644 --- a/library/src/main/java/com/paypal/messages/ModalFragment.kt +++ b/library/src/main/java/com/paypal/messages/ModalFragment.kt @@ -325,7 +325,7 @@ internal class ModalFragment( // This function is called when the modal is usually already instantiated override fun onViewCreated(view: View, savedInstanceState: Bundle?) { - logEvent(AnalyticsEvent(eventType = EventType.MODAL_OPENED)) + logEvent(AnalyticsEvent(eventType = EventType.MODAL_VIEWED)) this.onLoading() val url = Api.createModalUrl(clientId, amount, buyerCountry, offerType) diff --git a/library/src/main/java/com/paypal/messages/analytics/EventType.kt b/library/src/main/java/com/paypal/messages/analytics/EventType.kt index 6ed26a2..771b1c8 100644 --- a/library/src/main/java/com/paypal/messages/analytics/EventType.kt +++ b/library/src/main/java/com/paypal/messages/analytics/EventType.kt @@ -5,7 +5,7 @@ enum class EventType { MESSAGE_CLICKED, MODAL_RENDERED, MODAL_CLICKED, - MODAL_OPENED, + MODAL_VIEWED, MODAL_CLOSED, MODAL_ERROR, ; diff --git a/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt b/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt index ca1e5aa..76b29de 100644 --- a/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt +++ b/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt @@ -26,7 +26,7 @@ class EventTypeTest { @Test fun testModalOpen() { - assertEquals(EventType.MODAL_OPENED.toString(), "modal_opened") + assertEquals(EventType.MODAL_VIEWED.toString(), "modal_opened") } @Test