Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Implement DDP Atmos encoding #31

Open
pcroland opened this issue Aug 16, 2022 · 50 comments
Open

[REQUEST] Implement DDP Atmos encoding #31

pcroland opened this issue Aug 16, 2022 · 50 comments
Labels
feature request New feature or request

Comments

@pcroland
Copy link
Owner

No description provided.

@pcroland pcroland added the feature request New feature or request label Aug 16, 2022
@pcroland
Copy link
Owner Author

pcroland commented Oct 2, 2022

It's possible from DDP abd TrueHD aswell.

@pcroland
Copy link
Owner Author

pcroland commented Oct 2, 2022

No, with DRP and DEE.

@argonan0
Copy link

argonan0 commented Oct 10, 2022

Well, the encoding only is possible from .atmos or .adm files, so...

What if the source is an Atmos stream?

@pcroland
Copy link
Owner Author

DRP and gstreamer can decode atmos, no need to use ADM.

@xEsteem
Copy link

xEsteem commented Mar 17, 2023

+1 on this, for encoding ddp-joc from trueHD would be amazing to support

@jessielw
Copy link
Collaborator

jessielw commented Apr 5, 2023

@pcroland could you elaborate further what is needed to take THD and convert it to eac3 atmos? I might be able to assist.

@hyllm
Copy link

hyllm commented Apr 22, 2023

i really like to know that either.

@pcroland
Copy link
Owner Author

Atmos JOC is not possible from just a TrueHD source

@jessielw
Copy link
Collaborator

We actually found a way and developed it. We'll be open sourcing it in the next month or so.

@hyllm
Copy link

hyllm commented Apr 22, 2023

can i try? :) i am willing to pay for it. :) send pm if open for testing. :)

@jessielw
Copy link
Collaborator

Atmos JOC is not possible from just a TrueHD source

It is actually possible from the TrueHD source. If the source is untouched (had no dialnorm ran on it) it will decode to what ever preset of channels you'd like easily.

can i try? :) i am willing to pay for it. :) send pm if open for testing. :)

We actually have a stable version of it done. However, we're re-writing the tool and we'll open source it. Right now it's 1 large script and we're re writing it in OOP.

@pcroland
Copy link
Owner Author

Does it use DEE for encoding with a custom decoder or does the project have an encoder aswell?

@hyllm
Copy link

hyllm commented Apr 22, 2023

can't wait to test it. :) i got 5.1.2 atmos setup, so keeping large truehd with atmos is no benefit for me... 768kbps JOC will be great. :D can't wait to test. :)

@jessielw
Copy link
Collaborator

Does it use DEE for encoding with a custom decoder or does the project have an encoder aswell?

Uses a custom decoder but uses DEE to encode.

Actually we started the project based off of deew.

So totally open to working together.

@hyllm
Copy link

hyllm commented Apr 22, 2023

Atmos JOC is not possible from just a TrueHD source

LG C9 has no problem transcoding THD to EAC3 while preserving Atmos. And of course even now it is possible if you have both THD and EAC3 source by using EAC3 panning metadata and WAV layer from THD (by using Cavern's special secret option).

can you write more? :) i want to try. :)

@jessielw
Copy link
Collaborator

Atmos JOC is not possible from just a TrueHD source

LG C9 has no problem transcoding THD to EAC3 while preserving Atmos. And of course even now it is possible if you have both THD and EAC3 source by using EAC3 panning metadata and WAV layer from THD (by using Cavern's special secret

I'm decoding with dolbys reference player.

@jessielw
Copy link
Collaborator

We'll open source it soon. Works 100% of the time as long as THD has not been manipulated in anyway with dialnorm.

So straight from bluray it always works.

@pcroland
Copy link
Owner Author

Does it use DEE for encoding with a custom decoder or does the project have an encoder aswell?

Uses a custom decoder but uses DEE to encode.

Actually we started the project based off of deew.

So totally open to working together.

Could you write an e-mail or message me on Telegram?

@hyllm
Copy link

hyllm commented Apr 22, 2023

Atmos JOC is not possible from just a TrueHD source

LG C9 has no problem transcoding THD to EAC3 while preserving Atmos. And of course even now it is possible if you have both THD and EAC3 source by using EAC3 panning metadata and WAV layer from THD (by using Cavern's special secret option).

can you write more? :) i want to try. :)

Sure. EAC3 has 256 samples of silence in front so you need to add that to THD track decoded to WAV ADM, note that. Secret option is called --override-bed, I asked for it here: VoidXH/Cavern#78

whare to put the command line... what tool??? cavern64 itself is gui... or am i missing something? :)

@jessielw
Copy link
Collaborator

Cavernize GUI opens command line first, because it is compiled in Visual Studio using CLI option. Even if it has gui you can still use it as command line utility.

as long as THD has not been manipulated in anyway with dialnorm.

Does THD 4th actual (Atmos) substream uses Huffman too as EAC3 does? Did you stole the tables? Nuts, guys.

I don't understand what you're saying?

@hyllm
Copy link

hyllm commented Apr 22, 2023

Cavernize GUI opens command line first, because it is compiled in Visual Studio using CLI option. Even if it has gui you can still use it as command line utility. <

so merge first 256 EAC3 5.1 samples with truehd with atmos stream, then decode to adm wav??? can you write telegram/signal or PM here? i am kind of confused... but maybe i drunk too much last night. :D :D

@jessielw
Copy link
Collaborator

don't understand what you're saying?

Then how did you extract panning metadata to ADM with panning metadata? And how did you wrote the code that extracted all 16 objects from 8 channels? After that Cavern or even Davinci Resolve can be used to render it.

Dolby official libraries to decode the atmos data into what ever channel format is wanted.

@pcroland
Copy link
Owner Author

@jlw4049 e-mail or tg? 👀

@jessielw
Copy link
Collaborator

Anyone interested in it can reach me on discord.

jlw_4049#1867

@hyllm
Copy link

hyllm commented Apr 22, 2023

Anyone interested in it can reach me on discord.

jlw_4049#1867

sent you request

@jessielw
Copy link
Collaborator

jessielw commented Apr 22, 2023

official libraries to decode the atmos data into what ever channel format is wanted.

That is useless. Channel format is not needed by me or anyone, we need object format with panning metadata. That is closest to master format even if some of 128 objects are unified.

I guess this is useless decoded/encoded from a bluray thd track. Hmm

😀

image.png

@pcroland
Copy link
Owner Author

Also sent you a request on DC.

@hyllm
Copy link

hyllm commented Apr 22, 2023

or PM here

There is no PM on github. Those 256 samples are always silence, it is called encoder delay. Yes, you add 256 samples to the base layer, "bed", it will not allow you to proceed to ADM without that.

mail? discord? telegram?

@jessielw
Copy link
Collaborator

guess this is useless decoded/encoded from a bluray thd track. Hmm

That will not have any moving objects, it will be fake Atmos. Did you look with cavern driver (Unity), do the objects move after you encode EAC3?

Yes all the channels work after encoded.

@hyllm
Copy link

hyllm commented Apr 22, 2023

mail?

My mail is public on https://github.com/ValZapod

sent you mail

@jessielw
Copy link
Collaborator

We've also confirmed it on atmos equipment before/after encoding it. Identical sound, works great.

@pcroland
Copy link
Owner Author

Does the decoder just use a hidden option in DRP or some extra stuff aswell?

@jessielw
Copy link
Collaborator

Yes all the channels work after encoded.

That is not what I asked you and that is not useful, see these videos under the username that show moving objects: https://www.youtube.com/watch?v=7bEEnLqOXyA

I see those. But I'm not manipulating the data in anyway myself. Its with dolby libraries, decoding, encoding with DEE.

I can run my output file through a test if you'd like to provide what ever software that is to check it.

@jessielw
Copy link
Collaborator

But I'm not manipulating the data in anyway myself.

If you produce rendered file at any point, all panning metadata is gone, and it is FAKE atmos. Yes, there can still be more channels than 8 channels, and top channels will be there, sure, but Atmos will still be fake.

I can run my output file through a test if you'd like to provide what ever software that is to check it.

Please! 🤗

Let me know how to test like that video

@jessielw
Copy link
Collaborator

jessielw commented Apr 23, 2023

So I spent the a chunk of the night testing what you said. What I've noticed, is not ALL atmos tracks have panning metadata. However, the ones that do have that metadata, it is lost with my decode.

So, I do have a reliable way to decode/encode it. I do not have a reliable way to actually retain the panning metadata.

@Mamacito473
Copy link

Mamacito473 commented Jun 21, 2023

So any idea on how to encode THD Atmos to DDP JOC Atmos ?

@lion9994
Copy link

Any progress jlw_4049?

@pcroland
Copy link
Owner Author

Someone else is working on it, no ETA, no need to ask when it will be ready, if it ever will be

@lion9994
Copy link

could you give me the link pleas

@pcroland
Copy link
Owner Author

What link?

@lion9994
Copy link

What's about DEEW with DDE isn't enough to encoding DD+ With atmos(EAC3-JOC) ?

@pcroland
Copy link
Owner Author

From a TrueHD file no.

@lion9994
Copy link

I find way if you're interest contact with me on discord
Screenshot_٢٠٢٣٠٨١٧_٢٣٤٧٠٦_Chrome

@hyllm
Copy link

hyllm commented Aug 18, 2023

I find way if you're interest contact with me on discord Screenshot_٢٠٢٣٠٨١٧_٢٣٤٧٠٦_Chrome

and what about 7.1 EAC3 with JOC?

@pcroland
Copy link
Owner Author

Its probably another drp dump encoded with dee with no real metadata, no need to get hyped.

@lion9994
Copy link

lion9994 commented Aug 18, 2023

Screenshot_٢٠٢٣٠٨١٨_١٠٤١٤٥_Chrome

Its probably another drp dump encoded with dee with no real metadata, no need to get hyped.

No, is there real metdata, but the volume will be reduce, i don't know what the specific issue till now.

Repository owner deleted a comment from Mamacito473 Aug 18, 2023
Repository owner deleted a comment from hyllm Aug 18, 2023
Repository owner deleted a comment from hyllm Aug 18, 2023
@pcroland
Copy link
Owner Author

Stop spamming discord contacts, join the Telegram group

@LastBreeze
Copy link

LastBreeze commented Jun 8, 2024

Stop spamming discord contacts, join the Telegram group

Where's the link to the telegram group? Did a ctrl+f for "telegram" and "group" and read every individual message, I might be blind lol, thank you for your time and thank you for all of your work.

@pcroland
Copy link
Owner Author

pcroland commented Jun 9, 2024

You might be, It's at the top of the readme with a Telegram logo.

@pcroland pcroland reopened this Jun 9, 2024
@pcroland
Copy link
Owner Author

pcroland commented Jun 9, 2024

And also at the bottom of the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants