Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JSON compression #256

Open
pdinklag opened this issue Aug 1, 2024 · 1 comment
Open

Disable JSON compression #256

pdinklag opened this issue Aug 1, 2024 · 1 comment
Labels
Change Request Things that could be better.

Comments

@pdinklag
Copy link
Owner

pdinklag commented Aug 1, 2024

Some webservers integrate automatic compression of JSON files. This breaks asynchronous downloads of json.gz files via AJAX, which the MinecraftStats client then cannot decompress. The reasons are not entirely clear to me, but this has been a problem in the past.

In any event, since server-side compression can apparently be considered standard functionality, this means that MinecraftStats should no longer do it and move that responsibility to the admin.

@pdinklag
Copy link
Owner Author

pdinklag commented Aug 6, 2024

Note to self: The transition may become a bit messy with many people going stuck in loading clocks. However, since something like #257 is currently missing, there is no nice way around that.

To avoid any confusion, the updater should actively delete any existing summary.json.gz file. This will force admins to do something, ideally ask what's up on Discord or just update the client on their own. The release notes should very clearly state this intent.

pdinklag added a commit that referenced this issue Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Request Things that could be better.
Projects
None yet
Development

No branches or pull requests

1 participant