-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDM doesn't benefit significantly from its cache #2801
Comments
Regarding caching, PDM 2.14.0 just reverts what was done in PDM 2.13, so I expect cache performance to be strictly the same than PDM 2.12. |
Might be related to the explanation here: #2964 (comment)
My reproduction is far simpler with just a few explicit |
I have similar issue with Gitlab CI cache. This method works for me with poetry $ pdm use -f $PYTHON_VENV_DIR
INFO: Using the first matched interpreter.
Using Python interpreter: /builds/.../master/.venv/bin/python (3.11)
INFO: PDM 2.17.1 is installed, while 2.19.1 is available.
Please run `pdm self update` to upgrade.
Run `pdm config check_update false` to disable the check.
$ pdm sync --dev --fail-fast
STATUS: Resolving packages from lockfile...
All packages are synced to date, nothing to do.
Installing the project as an editable package...
✔ Update myproject 0.154.0 -> 0.154.0 successful
🎉 All complete!
INFO: PDM 2.17.1 is installed, while 2.19.1 is available.
Please run `pdm self update` to upgrade.
Run `pdm config check_update false` to disable the check.
------
$ mypy app tests
pyproject.toml:1: error: Error importing plugin "sqlalchemy.ext.mypy.plugin": No module named 'sqlalchemy' [misc] |
Actual behavior
We did several tries to cache PDM cache on our Gitlab CI and we were surprised of how little it improved
pdm sync
performances. Until PDM 2.13, PDM was taking 1m57 to install our long list of dependencies, and 1m43 with a filled cache. Cache restauration time on our Gitlab is ~10 secondes so it was not worth it.With PDM 2.13+, timing moved to 6m20 for an installation with empty cache to 4m35, so yes caching became finally worth it but you see the problem.
Expected behavior
I don't know if this can be fixed/improved. If you think you it can, that's awesome. If you think it's all normal, I'll close the issue.
Steps to reproduce
I did a small demonstration repo, pdm-cache-demonstrator , with a very simple reproducible case and long dependencies list, similar to the our production dependencies. There is a
pdm cache info
command before eachpdm sync
, andpdm sync
is run with-v
. We get somewhat similar results that what we experience, but less exacerbated:pdm 2.12.4, empty cache: 1m38
pdm 2.12.4, filled cache: 0m57
pdm 2.13.3, empty cache: 2m37
pdm 2.13.3, filled cache: 2m9
Environment Information
For PDM 2.12:
It would be the same for PDM 2.13
The text was updated successfully, but these errors were encountered: