Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling selector to look like a native android component #135

Open
jadeirving9 opened this issue Feb 27, 2020 · 3 comments
Open

Styling selector to look like a native android component #135

jadeirving9 opened this issue Feb 27, 2020 · 3 comments

Comments

@jadeirving9
Copy link

Hi,
I really like the component and don't want to use anything else because it has a wealth of accessible functionality, which my application requires. However, the component does not fit with the rest of my application. Is there a way to drop the styling so it looks like a native component? It's ok on iOS but on Android it looks like an iOS component. Thanks

@peacechen
Copy link
Owner

There are a number of styling props to make it look the way you prefer, though admittedly there are quite a lot to change:
https://github.com/peacechen/react-native-modal-selector#props

Making the default an Android style would disrupt iOS apps. Ideally this library would support themes, possibly with default styles for Android vs iOS. The app uses a typical stylesheet that could be overridden by a prop:
https://github.com/peacechen/react-native-modal-selector/blob/master/index.js#L17

It could also check the platform OS and select between Android vs iOS default stylesheets.

Would you be interested in submitting a PR?

@jadeirving9
Copy link
Author

So, there aren't specific style props I can 'reset', I would have to re-style the whole thing?

@peacechen
Copy link
Owner

It probably wouldn't look like "Android" if all the styling was removed. If you'd like to try, pass in an empty array [] to all the style props.

This a community supported open source library. Your contributions would help not only yourself but others who use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants