Skip to content

PHP8.4 Fix Implicitly nullable parameter deprecation #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025
Merged

PHP8.4 Fix Implicitly nullable parameter deprecation #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Log.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ public function flush(): bool
* Abstract implementation of the log() method.
* @since Log 1.0
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion Log/composite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public function flush(): bool
*
* @return boolean True if the entry is successfully logged.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/console.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public function flush(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/daemon.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function close(): bool
* LOG_ERR, LOG_WARNING, LOG_NOTICE, LOG_INFO,
* and LOG_DEBUG. The default is LOG_INFO.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/display.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public function close(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/error_log.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public function close(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/file.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ public function flush(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/firebug.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public function flush(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/mail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public function flush(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/mcal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public function close(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/mdb2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public function setIdent(string $ident): void
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/sql.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public function setIdent(string $ident): void
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/sqlite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public function close(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/syslog.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function close(): bool
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down
2 changes: 1 addition & 1 deletion Log/win.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ private function writeln(string $line): void
* PEAR_LOG_NOTICE, PEAR_LOG_INFO, and PEAR_LOG_DEBUG.
* @return boolean True on success or false on failure.
*/
public function log($message, int $priority = null): bool
public function log($message, ?int $priority = null): bool
{
/* If a priority hasn't been specified, use the default value. */
if ($priority === null) {
Expand Down