Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

q: relationship with pear-core-minimal? #142

Open
gggeek opened this issue Jul 26, 2024 · 3 comments
Open

q: relationship with pear-core-minimal? #142

gggeek opened this issue Jul 26, 2024 · 3 comments

Comments

@gggeek
Copy link

gggeek commented Jul 26, 2024

Should this package replace pear-core-minimal or implement some api specified by it?

@ashnazg
Copy link
Member

ashnazg commented Jul 26, 2024

Minimal is a tiny subset of the core package, for when another package has a dependency on the smallest pieces from core.

@gggeek
Copy link
Author

gggeek commented Jul 27, 2024

@ashnazg thanks. Let me explain better my question.

It stems from finding a package (pear_ole) which does not declare a dependency on either pear-core or pear-core-minimal. And, since it does make use of some of the classes found in pear-core-minimal, when installing it in a project via Composer, it throws an error (see nick322/secure-spreadsheet#24)

I wanted to know
A. if it is correct / standard practice for that package to state a dependency on pear-core-minimal, and
B. if the pear-core package includes the same classes which are in pear-core-minimal

If B is true, then I think that this package should have "replace": "pear-core-minimal" in its composer.json, as:

  • it would avoid scenarios where both pear-core-minimal and pear-core get installed
  • it would allow users to install pear-core and have their project working fine, when one of their dependencies requires pear-core-minimal

@gggeek
Copy link
Author

gggeek commented Oct 12, 2024

I think that this project should also declare "replace": "pear_exception" - as that Composer package is a single class which is also included here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants