Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis treatment for axisymmetric #102

Open
trevilo opened this issue Feb 7, 2022 · 0 comments
Open

Axis treatment for axisymmetric #102

trevilo opened this issue Feb 7, 2022 · 0 comments
Assignees

Comments

@trevilo
Copy link
Contributor

trevilo commented Feb 7, 2022

As noted in #98, the initial treatment of the axis for axisymmetric flow is not optimal. Specifically, in RHSoperator any source terms (implemented by deriving from the ForcingTerms class) are added after applying the inverse mass matrix. This leads to a requirement that we evaluate 1/radius in the axisymmetric source terms, which is clearly a problem on the axis.

This can be avoided by evaluating the source terms (at least for axisymmetric) prior to applying the inverse mass matrix. This ticket is to do that.

@trevilo trevilo self-assigned this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant