Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure CI on local runners cleans up #254

Open
trevilo opened this issue Mar 2, 2024 · 0 comments
Open

Make sure CI on local runners cleans up #254

trevilo opened this issue Mar 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@trevilo
Copy link
Contributor

trevilo commented Mar 2, 2024

We have observed some recent build failures (e.g., here on PR #251) that appear to be due to a failure of the CI scripts to clean up after themselves. Specifically, the offending build gave the following link error:

/usr/bin/ld: ./.libs/libtps.so: undefined reference to `GaussianInterpExtData::GaussianInterpExtData(mfem::ParMesh*, LoMachOptions*, TPS::Tps*)'

which is nonsensical b/c the GaussianInterExtData class was not introduced until PR #253.

But, these PRs did kick of the automated CI on marvin in such a way that if the CI from PR #253 ran and didn't clean up sufficiently well, a stale object from that build could have caused a problem for the next CI run on PR #251.

So, that is the current hypothesis. If correct, the fix is to make sure each build cleans up after itself.

@trevilo trevilo added the bug Something isn't working label Mar 2, 2024
@trevilo trevilo self-assigned this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant