.perlcriticrc

# global perlcritic configuration
#

# nice output, to easily see the POD of the policy
verbose  = [%p] %m at %f line %l, near '%r'\n

# severity of 3 is a good start (1 is very strict, 5 very tolerant)
severity = 3

# We don't check for perl tidyness because we run perltidy in the git
# pre-commit hook anyway.

[Subroutines::ProhibitExcessComplexity]
severity = 5

# Regexps
#

# we want to use // without //ms
[-RegularExpressions::RequireDotMatchAnything]
[-RegularExpressions::RequireLineBoundaryMatching]

[-RegularExpressions::RequireExtendedFormatting]
minimum_regex_length_to_complain_about = 5

[-RegularExpressions::ProhibitComplexRegexes]

# Documentation
#

# we don't want these POD rules
[-Documentation::RequirePodSections]

# We don't care about POD links 
[-Documentation::RequirePodLinksIncludeText]


# Variables
#

# we use $@ and $!
[-Variables::ProhibitPunctuationVars] 

# We want to be able to use Carp::Verbose in our tests scripts, so
# we add Carp to the whitelist
[Variables::ProhibitPackageVars]
packages = Data::Dumper File::Find FindBin Log::Log4perl Carp

# Values & Expressions
#

[-ValuesAndExpressions::ProhibitEmptyQuotes]

# I really don't think q{/} is more readable than '/'...
[-ValuesAndExpressions::ProhibitNoisyQuotes]

# Perl::Critic recommends Readonly, but this IS BAD!
# we use Const::Fast instead, but this policy keeps poping up.
[-ValuesAndExpressions::ProhibitMagicNumbers]

# want to be able to do :
#
#  defined $label && length($label)
#        or croak("label can't be empty")
#
[-ValuesAndExpressions::ProhibitMixedBooleanOperators]

# Modules
#

# we want to be able to build DSLs
[-Modules::ProhibitAutomaticExportation]

# We only want the main module to provide $VERSION
[-Modules::RequireVersionVar]


# Subroutines
#

# we want to be able to define short getters
[-Subroutines::RequireFinalReturn]

# we cant do @_ mesures with that one
[-Subroutines::RequireArgUnpacking]

# name is a common used name for methods
# but forbidden by this policy ...
[-Subroutines::ProhibitBuiltinHomonyms]

# some old libs use many args, we don't want to block that for now
[-Subroutines::ProhibitManyArgs]

# we allo protected subs
[-Subroutines::ProhibitUnusedPrivateSubroutines]

# Miscellanea
#

# We're not under CVS! :)
[-Miscellanea::RequireRcsKeywords]

[TestingAndDebugging::ProhibitNoStrict]
allow = refs

[TestingAndDebugging::ProhibitNoWarnings]
allow = redefine prototype

[TestingAndDebugging::RequireUseStrict]
equivalent_modules = Weborama::Standard Test::Most Test::Class::Most Dancer strictures Moo Moo::Role

[TestingAndDebugging::RequireUseWarnings]
equivalent_modules = Weborama::Standard Test::Most Test::Class::Most Dancer strictures Moo Moo::Role

# ControlStructures
#

# we use postifx controls
[-ControlStructures::ProhibitPostfixControls]

# we cant use the switch feature, because some code is deployed
# under Perl 5.8, so we allow if/elsif/else
[-ControlStructures::ProhibitCascadingIfElse]

# ErrorHandling
#

# this one involves complex code structures, we'll switch to Try::Tiny
# soon/
[-ErrorHandling::RequireCheckingReturnValueOfEval]

# We want to use croak everywhere instead of die
[ErrorHandling::RequireCarping]

# allow backtick if capture result
[InputOutput::ProhibitBacktickOperators]
only_in_void_context = 1

# allow constant pragma
[-ValuesAndExpressions::ProhibitConstantPragma]