Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to build against fribidi 1.0.8 #10

Open
aelmahmoudy opened this issue Jan 1, 2020 · 1 comment · May be fixed by #11
Open

Fails to build against fribidi 1.0.8 #10

aelmahmoudy opened this issue Jan 1, 2020 · 1 comment · May be fixed by #11

Comments

@aelmahmoudy
Copy link

aelmahmoudy commented Jan 1, 2020 •
edited
Loading

When building pyfribidi against fribidi 1.0.8, I got the following error:

======================================================================
FAIL: testNoReorderNonSpacingMarks (test_pyfribidi.UTF8Tests)
utf8: reorder non spacing marks
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builds/python-team/modules/pyfribidi/debian/output/pyfribidi-0.12.0+repack/.pybuild/cpython3_3.8/build/test_pyfribidi.py", line 146, in testNoReorderNonSpacingMarks
    self.assertEqual(pyfribidi.log2vis("חַיְפַא", RTL, reordernsm=False),
AssertionError: 'אפַיְחַ' != 'אַפְיַח'
- אפַיְחַ
+ אַפְיַח


======================================================================
FAIL: testNoReorderNonSpacingMarks (test_pyfribidi.UnicodeTests)
unicode: reorder non spacing marks
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builds/python-team/modules/pyfribidi/debian/output/pyfribidi-0.12.0+repack/.pybuild/cpython3_3.8/build/test_pyfribidi.py", line 90, in testNoReorderNonSpacingMarks
    self.assertEqual(pyfribidi.log2vis(u"חַיְפַא", RTL, reordernsm=False),
AssertionError: 'אפַיְחַ' != 'אַפְיַח'
- אפַיְחַ
+ אַפְיַח

I didn't face this issue when building against fribidi 1.0.7

See: fribidi/fribidi#136
aelmahmoudy added a commit to aelmahmoudy/pyfribidi that referenced this issue Jan 28, 2020
@aelmahmoudy
Fix testNoReorderNonSpacingMarks
7780427 
Fixes pediapress#10
@aelmahmoudy aelmahmoudy linked a pull request Jan 28, 2020 that will close this issue
Open
@aelmahmoudy
Copy link
Author

The difference between the two outputs in hex is as follows:

  • d790 d7a4 d6b7 d799 d6b0 d797 d6b7
  • d790 d6b7 d7a4 d6b0 d799 d6b7 d797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix testNoReorderNonSpacingMarks aelmahmoudy/pyfribidi
1 participant
@aelmahmoudy