Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Add Codable Support #36

Open
Mordil opened this issue Mar 8, 2020 · 1 comment
Open

[RFC] Add Codable Support #36

Mordil opened this issue Mar 8, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@Mordil
Copy link
Member

Mordil commented Mar 8, 2020

From the Introducing: "SwiftCurrency" thread on the Swift forums:

It is desired to conform AnyCurrency to Codable.

The question remains, how should the value encoded/decoded?:

  • Should it be a single string value? "300 USD" / "USD 300"
  • Should it be an object?
    • What should the keys be called?
    {
    "value": "30.03",
    "currency": "USD"
}
@Mordil Mordil added enhancement New feature or request question Further information is requested labels Mar 8, 2020
@Mordil
Copy link
Member Author

Mordil commented Mar 8, 2020

As part of this, LosslessStringConvertible conformance will also be nice / required.

@Mordil Mordil pinned this issue Mar 11, 2020
@Mordil Mordil changed the title Add Codable Support [RFC] Add Codable Support Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mordil