Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rules): natural-order rule #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(rules): natural-order rule #38

wants to merge 4 commits into from

Conversation

moritzjacobs
Copy link
Collaborator

@moritzjacobs moritzjacobs requested a review from jhnns September 18, 2020 11:14
@moritzjacobs moritzjacobs mentioned this pull request Sep 18, 2020
Open
jhnns
jhnns reviewed Jan 31, 2021
View reviewed changes
Copy link
Member

@jhnns jhnns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really check the code, but from a user perspective I'd expect the config object to look more like this:

{
	"strict": true,
	"rules": {
		"order": "natural"
	}
}

As soon as there's the possibility to specify an invalid configuration, people will do it 😁

src/rules/natural-order.ts
namespace: namespace.substr(4),
entry,
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 😁

@moritzjacobs
Copy link
Collaborator Author

Good point. This is so old, I can do my own review and maybe get this done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnns jhnns jhnns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Group scripts
2 participants
@moritzjacobs @jhnns