Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datamart reports and utilities to work with new AGB models #48

Open
operdeck opened this issue Apr 13, 2022 · 3 comments
Open

Datamart reports and utilities to work with new AGB models #48

operdeck opened this issue Apr 13, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@operdeck
Copy link
Collaborator

operdeck commented Apr 13, 2022

The new AGB variant of Adaptive has some differences wrt AB in what it stores in the predictor binning tables. One of the changes is there is no predictor binning like NB has, instead the bins are used to just list the possible values/ranges.

When currently running the standard Health check notebook on AGB data, the predictor performance plot shows odd values in the x-axis. The aggregate view of the predictors currently does not work.

The off-line model reports seem to show the classifier correctly, but need to verify the details. The predictors list looks off - strange values. The individual predictor binning is completely wrong/empty (as expected, but we need to provide an alternative view here for AGB).

@operdeck operdeck added the enhancement New feature or request label Apr 22, 2022
@StijnKas
Copy link
Collaborator

#55 adds support for analyzing the json export of the models in Python - but this issue is still relevant, as we need to update the Python tools to support AGB datamart (model & predictor data) still.

@StijnKas
Copy link
Collaborator

StijnKas commented Sep 1, 2022

#57 introduced further improvements in this area: can now extract AGB models directly from the modeldata column in the datamart, and use this to analyse multiple trees at once. This is still not finished by any means, so still very much open to any feedback.

@StijnKas
Copy link
Collaborator

Let's re-evaluate this with the new Python healthcheck. @operdeck @yusufuyanik1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants