Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracted separable street names working for autocomplete but not search #1558

Open
missinglink opened this issue Sep 20, 2021 · 1 comment
Labels

Comments

@missinglink
Copy link
Member

missinglink commented Sep 20, 2021

The address Grolmanstraße 1, 10623, Berlin, Germany fails for /v1/search when searching:
Grolmanstr. 1, 10623, Berlin, Germany.

This is an example of a wider bug which effects contracted separable street names.
note: this is not the case for /v1/autocomplete

Examples of different forms which should work for both endpoints:

  • Grolmanstraße 1, 10623, Berlin, Germany
  • Grolmanstrasse 1, 10623, Berlin, Germany
  • Grolmanstr. 1, 10623, Berlin, Germany
  • Grolmanstr 1, 10623, Berlin, Germany
  • Grolman Straße 1, 10623, Berlin, Germany
  • Grolman Strasse 1, 10623, Berlin, Germany
  • Grolman Str. 1, 10623, Berlin, Germany
  • Grolman Str 1, 10623, Berlin, Germany
@missinglink missinglink changed the title Contracted seperable street names working for search but not reverse Contracted seperable street names working for autocomplete but not search Sep 20, 2021
@missinglink missinglink changed the title Contracted seperable street names working for autocomplete but not search Contracted separable street names working for autocomplete but not search Sep 20, 2021
@orangejulius
Copy link
Member

orangejulius commented Sep 20, 2021

Huh weird, I would have thought we handled that back in pelias/model#119.

Looking at the raw response from Elasticsearch, we generate the following alt-names for the given address:

"name": {
  "default": [
    "1 Grolmanstraße",
    "1 Grolman Straße"
  ]
},

So I can definitely see how that would work for autocomplete, but not search. I'm kinda hesitant to add tons of alt names until we fix pelias/pelias#862 / pelias/openstreetmap#507, but we could at least try adding another one for -str?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants