Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place in OSM not found in Pelias after importing #497

Closed
mihaicosareanu-bolt opened this issue Aug 13, 2019 · 11 comments · Fixed by #498
Closed

Place in OSM not found in Pelias after importing #497

mihaicosareanu-bolt opened this issue Aug 13, 2019 · 11 comments · Fixed by #498

Comments

@mihaicosareanu-bolt
Copy link

Hi,

I'm trying to import the OSM data for the city of Ganja, Azerbaijan into pelias.

It seems that there are some places that exist in .pbf (I used pbf2json to find them), but they are not present in the elasticsearch index, or I can't seem to find them.

Here is an example of a place: https://www.openstreetmap.org/node/6600732186#map=19/40.68178/46.35879

Even when trying on the following link, I can't seem to find the place: https://geocode.earth/

If you encountered this type of issue before, any advice in how to debug and figure out why it doesn't work would be greatly appreciated :).

@missinglink
Copy link
Member

We have that restaurant in our production build:
https://pelias.github.io/compare/#/v1/place%3Fids=openstreetmap:address:node/6600732186

Can you please try the path /v1/place?ids=openstreetmap:address:node/6600732186 against your server to double-check that the document isn't in your index?

@missinglink
Copy link
Member

It might be that they are present but you aren't able to find them for one reason or another, if that's the case please share some of your queries.

@missinglink
Copy link
Member

Agh I know what it is actually, the name "Osmanli Doner" has been tagged name:en when Pelias expects the name to be in the form of another tag, usually name (but we also support others).

Could you please check if this is a common theme among your failures?

@mihaicosareanu-bolt
Copy link
Author

mihaicosareanu-bolt commented Aug 13, 2019

Hmm, I have that entry with the same output. However, the name is missing from the record. Here is the output of pbf2json:

{"id":6600732186,"type":"node","lat":40.681784,"lon":46.3587859,"tags":{"addr:housenumber":"247","addr:street":"Mustafa Kemal Ataturk","amenity":"restaurant","name:en":"Osmanli Doner","opening_hours":"24/7","phone":"+994502071884","website":"https://www.facebook.com/osmanliganja"}}

@missinglink
Copy link
Member

@mihaicosareanu-bolt
Copy link
Author

mihaicosareanu-bolt commented Aug 13, 2019

I think I understand. The place in OSM doesn't seem to have a default name, as others do. Would it be a good solution to make it fallback to the "name:en" if for some reason "name" doesn't exist?. What do you think?

@missinglink
Copy link
Member

Yes, it's an easy fix so I opened #498 to resolve it

@missinglink
Copy link
Member

If you're using the pelias/docker workflow then you can test this dev branch by editing your docker-compose.yml file so that the image points to pelias/openstreetmap:name_fallback instead of pelias/openstreetmap:master.

You can then rerun the opeenstreetmap import and please let me know if it solves your issue.
Please remember to revert that change to use pelias/openstreetmap:master once this PR is merged to master

@mihaicosareanu-bolt
Copy link
Author

mihaicosareanu-bolt commented Aug 13, 2019

I tested exactly as you mentioned and it works. That was an absolutely amazing response time! Thank you @missinglink, you are totally awesome :).

Proof:

"features": [
        {
            "type": "Feature",
            "geometry": {
                "type": "Point",
                "coordinates": [
                    46.358786,
                    40.681784
                ]
            },
            "properties": {
                "id": "node/6600732186",
                "gid": "openstreetmap:venue:node/6600732186",
                "layer": "venue",
                "source": "openstreetmap",
                "source_id": "node/6600732186",
                "name": "Osmanli Doner",
                "housenumber": "247",
                "street": "Mustafa Kemal Ataturk",
                "distance": 2525.261,
                "accuracy": "point",
                "label": "Osmanli Doner"
            }
        }
    ],

@missinglink
Copy link
Member

why is there no kebab emoji? 🤷‍♂

@missinglink
Copy link
Member

This functionality is now available in master via GitHub and the via docker tag 'master'.
It was introduced to master in docker tag master-2019-08-14-f897b8391e801b4e024b31ae9ff4d1868c1310d6.

michaelkirk pushed a commit to michaelkirk-pelias/openstreetmap that referenced this issue Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants