From 2996a13611546600cb4b13a34e3e9095b5af05fe Mon Sep 17 00:00:00 2001 From: Peter Johnson Date: Thu, 7 Nov 2024 10:39:51 +0100 Subject: [PATCH 1/2] feat(deps): update better-sqlite3 to work with node@v22 --- .github/workflows/_test.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index f3f1f859..2d01310e 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -7,7 +7,7 @@ jobs: matrix: os: - ubuntu-22.04 - node-version: [ 18.x, 20.x ] + node-version: [ 18.x, 20.x , 22.x ] steps: - uses: actions/checkout@v4 - name: 'Install node.js ${{ matrix.node-version }}' diff --git a/package.json b/package.json index c1d99afd..504f07c2 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ "dependencies": { "@hapi/joi": "^16.1.8", "async": "^3.0.1", - "better-sqlite3": "^8.5.0", + "better-sqlite3": "^11.5.0", "combined-stream": "^1.0.5", "command-exists": "^1.2.9", "download-file-sync": "^1.0.4", From 92718975872e2e67a0f7fb28b134f1834e8c4d33 Mon Sep 17 00:00:00 2001 From: Peter Johnson Date: Thu, 7 Nov 2024 10:47:23 +0100 Subject: [PATCH 2/2] feat(docker): update docker syntax 1 warning found (use docker --debug to expand): - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 9) --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 67c3c544..f39a68c7 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,7 +6,7 @@ FROM pelias/baseimage RUN apt-get update && apt-get install -y bzip2 lbzip2 unzip && rm -rf /var/lib/apt/lists/* # change working dir -ENV WORKDIR /code/pelias/whosonfirst +ENV WORKDIR=/code/pelias/whosonfirst WORKDIR ${WORKDIR} # copy package.json first to prevent npm install being rerun when only code changes