Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view pages for "simple" resources #963

Merged
merged 14 commits into from
Feb 24, 2025
Merged

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Jan 31, 2025

Adds view pages (#583) for the "simple" resources which means everything except Egg, Node and Server.

table and form methods were moved to the Resource class so the view pages can use a disabled form and to avoid duplicate code.


+ the table for mounts got a little rework:
grafik

@Boy132 Boy132 self-assigned this Jan 31, 2025
@Boy132 Boy132 requested a review from a team as a code owner January 31, 2025 09:12
@Boy132 Boy132 marked this pull request as draft January 31, 2025 16:35
lancepioch

This comment was marked as outdated.

@Boy132

This comment was marked as outdated.

…art-one

# Conflicts:
#	app/Filament/Admin/Resources/ApiKeyResource/Pages/CreateApiKey.php
#	app/Filament/Admin/Resources/ApiKeyResource/Pages/ListApiKeys.php
#	app/Filament/Admin/Resources/DatabaseHostResource.php
#	app/Filament/Admin/Resources/DatabaseHostResource/Pages/CreateDatabaseHost.php
#	app/Filament/Admin/Resources/DatabaseHostResource/Pages/EditDatabaseHost.php
#	app/Filament/Admin/Resources/DatabaseHostResource/Pages/ListDatabaseHosts.php
#	app/Filament/Admin/Resources/MountResource.php
#	app/Filament/Admin/Resources/MountResource/Pages/CreateMount.php
#	app/Filament/Admin/Resources/MountResource/Pages/EditMount.php
#	app/Filament/Admin/Resources/MountResource/Pages/ListMounts.php
#	app/Filament/Admin/Resources/RoleResource/Pages/EditRole.php
#	app/Filament/Admin/Resources/RoleResource/Pages/ListRoles.php
#	app/Filament/Admin/Resources/UserResource/Pages/CreateUser.php
#	app/Filament/Admin/Resources/UserResource/Pages/EditUser.php
#	app/Filament/Admin/Resources/UserResource/Pages/ListUsers.php
#	app/Filament/Admin/Resources/WebhookResource.php
#	app/Filament/Admin/Resources/WebhookResource/Pages/CreateWebhookConfiguration.php
#	app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
#	app/Filament/Admin/Resources/WebhookResource/Pages/ListWebhookConfigurations.php
@Boy132 Boy132 marked this pull request as ready for review February 9, 2025 17:38
…art-one

# Conflicts:
#	app/Filament/Admin/Resources/WebhookResource/Pages/CreateWebhookConfiguration.php
…art-one

# Conflicts:
#	app/Filament/Admin/Resources/ApiKeyResource/Pages/ListApiKeys.php
#	app/Filament/Admin/Resources/DatabaseHostResource/Pages/ListDatabaseHosts.php
#	app/Filament/Admin/Resources/MountResource/Pages/ListMounts.php
#	app/Filament/Admin/Resources/NodeResource/Pages/ListNodes.php
#	app/Filament/Admin/Resources/ServerResource/Pages/ListServers.php
#	app/Filament/Admin/Resources/WebhookResource/Pages/ListWebhookConfigurations.php
Copy link
Member

@lancepioch lancepioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but before merging, let's discuss this in team chat

@Boy132 Boy132 merged commit d53820b into main Feb 24, 2025
22 checks passed
@Boy132 Boy132 deleted the boy132/view-pages-part-one branch February 24, 2025 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants