Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate interactions with fuelSwitch mods #56

Open
pellinor0 opened this issue Nov 29, 2016 · 2 comments
Open

investigate interactions with fuelSwitch mods #56

pellinor0 opened this issue Nov 29, 2016 · 2 comments

Comments

@pellinor0
Copy link
Owner

pellinor0 commented Nov 29, 2016

There seem to be problems with several fuel switch mods lately, probably something changed in the base game. MFT applies resource costs twice (even when on its own), interaction with CC (configurable containers) also seems broken.

If FSfuelSwitch is present, I now ignore resource costs when calculating GetModuleCost. It might make sense to also do that for other fuelSwitch modules.

I recently changed to look at prefab-cost and prefab-resources when calculating dryCost (before: part-resources). This fixes things with FSFuelSwitch but might break something else. Overall it seems the more consistent thing to do.

List of fuel switch mods with TweakScale interaction:

  • FSFuelSwitch
  • configurableContainers
  • MFT (/realFuels)
  • B9PartSwitch
  • IFS
@blowfishpro
Copy link

There seem to be issues with RealFuels - TweakScale tells the tank module to rescale, so it modifies the mass, then the Tweakscale module also tries to modify the mass, which can result in negative mass for downscaled tanks. Would it be possible to disable TweakScale setting the mass on any part with a particular module?

KSP-RO/RealFuels#165

Not sure if ModularFuelTanks has the same issue or not.

@blowfishpro
Copy link

B9PartSwitch was working the last time I checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants