Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsoCode639_1 is ambiguous #163

Closed
bweben opened this issue Jan 23, 2023 · 2 comments
Closed

IsoCode639_1 is ambiguous #163

bweben opened this issue Jan 23, 2023 · 2 comments

Comments

@bweben
Copy link

bweben commented Jan 23, 2023

Hi

I'm trying to add a new language (or at least I'm trying to follow your contribution guide to add a new language).
Now I ran into a problem as the language Swiss German does not have a unique IsoCode639_1 code but probably shares the same as german. The IsoCode639_3 is GSW.

What is your preferred way to go forward? Add an imaginary IsoCode639_1 code? Or maybe add subfolders with the IsoCode639_3 code?

Thanks for your response and this awesome project.

@pemistahl
Copy link
Owner

Hi Nathanael, thank you for reaching out to me.

It's great that you want to contribute a Swiss German language model to Lingua. I think it's perfectly valid to use the existing IsoCode639_1.DE for Swiss German. You then just need to add IsoCode639_3.GSW as you have already found out. I haven't tried it yet but there should not be any problems if you assign the same iso code to more than one language. It is the correct way to do. If you encounter any problems with this approach, then please let me know.

Looking forward to your PR. Thanks a lot. Und viele Grüße in die Schweiz. :)

@bweben
Copy link
Author

bweben commented Jan 25, 2023

Hi Peter

OK, I created a PR now. I had to change some things, see #164

Besten Dank, viele Grüsse zurück nach Deutschland :D

@bweben bweben closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants