feat: #107: 24h stats design #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pages/trade/ui/summary.tsx
Outdated
| } | ||
| const change24h = data && { | ||
| positive: data.current_price >= data.price_24h_ago, | ||
| change: Number(data.current_price - data.price_24h_ago).toFixed(4), |
There was a problem hiding this comment.
Better to use round here as fixed doesn't actually round numbers correctly.
There was a problem hiding this comment.
Thanks, didn't know about this toFixed problem. Changed it everywhere to round, also in the shortify function
src/pages/trade/ui/summary.tsx
Outdated
| const change24h = data && { | ||
| positive: data.current_price >= data.price_24h_ago, | ||
| change: Number(data.current_price - data.price_24h_ago).toFixed(4), | ||
| percent: Number( |
src/pages/trade/ui/summary.tsx
Outdated
| <SummaryCard title='Price' loading={isLoading}> | ||
| {data && ( | ||
| <Text detail color='text.primary'> | ||
| {Number(data.current_price).toFixed(6)} |
src/pages/trade/ui/summary.tsx
Outdated
| <SummaryCard title='24h High' loading={isLoading}> | ||
| {data && ( | ||
| <Text detail color='text.primary'> | ||
| {Number(data.high_24h).toFixed(4)} |
There was a problem hiding this comment.
And here and so forth, we have the round fn in shared/utils
| * - 1000000 -> 1M | ||
| * - 1000000000 -> 1B | ||
| */ | ||
| export const shortify = (value: number): string => { |
There was a problem hiding this comment.
There's a package friendly-numbers. Perhaps it's more wise to use that.
There was a problem hiding this comment.
But it does just the same job, only the 'T' case (trillions) is not covered by me. Why would we need a library for that?
|
@JasonMHasperhoven do you mind re-reviewing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
Closes #108
Added styles and some neat animations for the stats block. Also, did some preliminary work towards #131
And mobile:
Animations:
shimmer.mp4