Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: 😄 add a CLI flag to use the LetsEncrypt staging environment #3681

Closed
cratelyn opened this issue Jan 26, 2024 · 0 comments · Fixed by #3705
Closed

pd: 😄 add a CLI flag to use the LetsEncrypt staging environment #3681

cratelyn opened this issue Jan 26, 2024 · 0 comments · Fixed by #3705
Labels
A-node Area: System design and implementation for node software C-enhancement Category: an enhancement to the codebase

Comments

@cratelyn
Copy link
Contributor

in #3652, @conorsch suggested:

It'd be nice to expose this as a CLI opt (preserving default=true) so that in test-only scenarios, we can use the staging api. For now, when we need to do that, we've just been editing this source, which is a fine workaround for devs.

we should do this! it will likely prove to be useful with future testing of the auto-https code, and other integration testing. (see #3336, for other notes on testing)

@cratelyn cratelyn added A-node Area: System design and implementation for node software C-enhancement Category: an enhancement to the codebase labels Jan 26, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Jan 26, 2024
conorsch added a commit that referenced this issue Jan 30, 2024
conorsch added a commit that referenced this issue Jan 31, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to Done in Penumbra Jan 31, 2024
TalDerei pushed a commit that referenced this issue Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: System design and implementation for node software C-enhancement Category: an enhancement to the codebase
Projects
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant