Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: testnet archives should include cometbft data #4525

Open
conorsch opened this issue Jun 3, 2024 · 0 comments
Open

ci: testnet archives should include cometbft data #4525

conorsch opened this issue Jun 3, 2024 · 0 comments
Assignees
@conorsch
Labels
_P-V1 Priority: slated for V1 release

Comments

@conorsch
Copy link
Contributor

conorsch commented Jun 3, 2024

Is your feature request related to a problem? Please describe.
As part of support for chain upgrades (#1804), we've started hosting minimal archives of post-migration state for late-joining nodes, e.g. #4520. Those archives include the post-migration genesis-file, a priv-validator-state json config with the upgrade height set as the minimum, and the historical rocksdb data.

Describe the solution you'd like
We should also include cometbft data in the historical archives. Doing so would allow reindexing of historical events into a sidecar database.

Describe alternatives you've considered
We could not do this. But we need to do it anyway for the services like the block explorer on the testnet, so we might as well document the procedure and support it.

Additional context
We have historical backups of pre-upgrade state that can be used to build the archives. During discussions with @erwanor, he pointed out that we want at least the cometbft data dir, plus config.toml and genesis. We should probably also recommmend running with flags like --p2p.pex=false and --p2p.seeds=''.
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jun 3, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 3, 2024
@conorsch conorsch mentioned this issue Jun 3, 2024
Closed
@conorsch conorsch self-assigned this Jun 3, 2024
@conorsch conorsch added this to the Sprint 8 milestone Jun 3, 2024
@aubrika aubrika moved this from Backlog to Todo in Penumbra Jun 3, 2024
@aubrika aubrika added _P-V1 Priority: slated for V1 release and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Jun 3, 2024
@conorsch conorsch mentioned this issue Jun 6, 2024
Closed
@conorsch conorsch mentioned this issue Jun 26, 2024
Merged
1 task
conorsch added a commit that referenced this issue Jun 27, 2024
@conorsch
docs: update archive url for testnet 78 (#4668)
a402222 
## Describe your changes
Refs #4582

Also relevant is #4525 which the archive referenced in this PR does
_not_ account for; 4524 is still outstanding.

To test this, one should be able to join the post-upgrade Testnet 78
with v0.78.0 of pd and sync blocks.
## Issue ticket number and link

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > docs-only

Co-authored-by: Conor Schaefer <[email protected]>
@aubrika aubrika modified the milestones: Sprint 8, Sprint 9 Jul 15, 2024
@aubrika aubrika modified the milestones: Sprint 9, Sprint 10 Aug 12, 2024
@aubrika aubrika removed this from the Sprint 10 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorsch conorsch

Labels
_P-V1 Priority: slated for V1 release
Projects
Penumbra
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conorsch @aubrika