Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcli should not depend on rocksdb #4534

Open
hdevalence opened this issue Jun 4, 2024 · 2 comments
Open

pcli should not depend on rocksdb #4534

hdevalence opened this issue Jun 4, 2024 · 2 comments

Comments

@hdevalence
Copy link
Member

Describe the bug

Two compounding errors during development led to pcli depending on all of rocksdb:

  1. pcli imports the entire app crate in order to run stateless checks before submitting the transaction; this was originally intended for debugging and is not necessary.
  2. The app crate is not split, like the other penumbra crates, into a component feature that gates all of the component logic behind a feature flag, allowing access to its data structures without the logic.

This causes problems for users trying to use pcli in high-security contexts that don't have glibc.

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jun 4, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 4, 2024
@cratelyn
Copy link
Contributor

cratelyn commented Jun 4, 2024

🙋‍♀️ i would like to tentatively sign up for this, pending refinement. cc: @aubrika

@aubrika aubrika added _P-V1 Priority: slated for V1 release _P-high High priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Jun 5, 2024
@cratelyn cratelyn added this to the Sprint 8 milestone Jun 5, 2024
@cratelyn cratelyn moved this from Backlog to In progress in Penumbra Jun 5, 2024
@cratelyn cratelyn self-assigned this Jun 5, 2024
@hdevalence hdevalence removed _P-V1 Priority: slated for V1 release _P-high High priority labels Jun 7, 2024
@hdevalence
Copy link
Member Author

Re-prioritizing to low since the users in question found a workaround.

@cratelyn cratelyn removed this from the Sprint 8 milestone Jun 7, 2024
@cratelyn cratelyn removed their assignment Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

3 participants