Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pindexer: ⏰ add AppView mapping height to timestamps #4675

Closed
cratelyn opened this issue Jun 27, 2024 · 1 comment · Fixed by #4713
Closed

pindexer: ⏰ add AppView mapping height to timestamps #4675

cratelyn opened this issue Jun 27, 2024 · 1 comment · Fixed by #4713
Assignees
@vacekj
Labels
A-indexing Area: Relates to event indexing.
Milestone
Sprint 9

Comments

@cratelyn
Copy link
Contributor

cratelyn commented Jun 27, 2024 •
edited
Loading

other indexes include a mapping from block height to timestamp. add an app view that does just that, as a stepping stone towards the views for block contents (#4674) and trading volume (#4673).

penumbra-zone/dex-explorer#25
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jun 27, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 27, 2024
@cratelyn cratelyn added A-indexing Area: Relates to event indexing. and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Jun 27, 2024
@cratelyn cratelyn self-assigned this Jun 27, 2024
@cratelyn cratelyn moved this from Backlog to In progress in Penumbra Jun 27, 2024
@cratelyn
Copy link
Contributor Author

see #4522 / #4523 for an RPC that returns consensus timestamps based on height.

@cronokirby cronokirby assigned vacekj and unassigned cratelyn and vacekj Jul 16, 2024
@cronokirby cronokirby moved this from In progress to Todo in Penumbra Jul 16, 2024
@cronokirby cronokirby added this to the Sprint 9 milestone Jul 16, 2024
@vacekj vacekj self-assigned this Jul 16, 2024
@vacekj vacekj moved this from Todo to In progress in Penumbra Jul 16, 2024
@vacekj vacekj linked a pull request Jul 16, 2024 that will close this issue
feat: add timestamp indexing wip #4713
Merged
This was referenced Jul 17, 2024
Merged
Merged
vacekj added a commit that referenced this issue Jul 18, 2024
@vacekj
feat: add timestamp to all event protos (#4722)
e360740 
## Describe your changes

this makes a non-consensus-breaking change, adding a timestamp field to
the EventBlockRoot proto.
This will be used to keep track of the timestamp of the block for use in
pindexer.

I tested this by running a local devnet with the changes to core. Pd
runs fine and the timestamps are correctly propagated to the raw events
db.

## Issue ticket number and link

prerequisite for #4675

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

- only adds a field
- adds this field to an Event proto
@vacekj vacekj closed this as completed in 7142295 Jul 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Jul 19, 2024
cronokirby pushed a commit that referenced this issue Jul 22, 2024
@vacekj @cronokirby
feat: add timestamp to all event protos (#4722)
741eed2 
this makes a non-consensus-breaking change, adding a timestamp field to
the EventBlockRoot proto.
This will be used to keep track of the timestamp of the block for use in
pindexer.

I tested this by running a local devnet with the changes to core. Pd
runs fine and the timestamps are correctly propagated to the raw events
db.

prerequisite for #4675

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

- only adds a field
- adds this field to an Event proto
@cronokirby cronokirby mentioned this issue Jul 22, 2024
Merged
2 tasks
cronokirby added a commit that referenced this issue Jul 22, 2024
@cronokirby @vacekj @conorsch
(backport) feat: add timestamp to all event protos (#4722) (#4734)
f407c53 
this makes a non-consensus-breaking change, adding a timestamp field to
the EventBlockRoot proto.
This will be used to keep track of the timestamp of the block for use in
pindexer.

I tested this by running a local devnet with the changes to core. Pd
runs fine and the timestamps are correctly propagated to the raw events
db.

prerequisite for #4675

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

- only adds a field
- adds this field to an Event proto

## Describe your changes

## Issue ticket number and link

## Checklist before requesting a review

- [ ] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF)

---------

Co-authored-by: Josef <[email protected]>
Co-authored-by: Conor Schaefer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vacekj vacekj

Labels
A-indexing Area: Relates to event indexing.
Projects
Penumbra
Archived in project
Milestone
Sprint 9
Development

Successfully merging a pull request may close this issue.

feat: add timestamp indexing wip penumbra-zone/penumbra
3 participants
@vacekj @cronokirby @cratelyn