Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimulateTrade is incorrectly included in "expensive RPCs" #4696

Closed
hdevalence opened this issue Jul 4, 2024 · 0 comments · Fixed by #4697
Closed

SimulateTrade is incorrectly included in "expensive RPCs" #4696

hdevalence opened this issue Jul 4, 2024 · 0 comments · Fixed by #4697
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@hdevalence
Copy link
Member

Describe the bug

pd contains a flag, --enable-expensive-rpc, that enables RPC endpoints believed to be more expensive and therefore unsuitable to expose by default.

Currently, this includes the SimulateTrade RPC, which turns out to not be expensive, as long as the node is running on hardware with a reasonable SSD.

The SimulateTrade RPC should be moved out of the "expensive RPC" category, so it is enabled by default.

This may mean the category is empty. That's fine. The flag can be a no-op, preserving the same semantics -- in case expensive RPC is ever added in the future. This avoids changing deployment setups.

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jul 4, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant