Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMD Sliding Window Algorithm has an edge case bug #4705

Open
cronokirby opened this issue Jul 9, 2024 · 0 comments
Open

FMD Sliding Window Algorithm has an edge case bug #4705

cronokirby opened this issue Jul 9, 2024 · 0 comments
Labels
C-bug Category: a bug

Comments

@cronokirby
Copy link
Contributor

cronokirby commented Jul 9, 2024

Precision::new(1u8).expect("1 is a valid precision")

In the case that there have been an estimated 0 clues over the past window, the targeted precision should be 0 (detect all clues) and not 1 (detect 50% of all clues).

One way to solve this in a non-consensus-breaking way is to add a flag to the algorithm in protobuf which will enable the fix here.

Also, this being wrong shouldn't cause clients to break, only that they use a sub-optimal precision for when transactions start up again.

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jul 9, 2024
@cronokirby cronokirby added the C-bug Category: a bug label Jul 9, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 9, 2024
@cronokirby cronokirby removed the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: a bug
Projects
Status: Backlog
Development

No branches or pull requests

1 participant