Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pindexer: dex: implement /api/lp related events and tables #4739

Closed
Tracked by #4750
cronokirby opened this issue Jul 23, 2024 · 0 comments · Fixed by #4771
Closed
Tracked by #4750

pindexer: dex: implement /api/lp related events and tables #4739

cronokirby opened this issue Jul 23, 2024 · 0 comments · Fixed by #4771
Assignees
@vacekj @cronokirby
Labels
A-indexing Area: Relates to event indexing.
Milestone
Sprint 9

Comments

@cronokirby
Copy link
Contributor

We should implement feature parity with the following api:
https://github.com/penumbra-zone/dex-explorer/tree/2b70ae60529284309f8748f6ca6a154a2bab82a9/src/pages/api/lp
@cronokirby cronokirby added the A-indexing Area: Relates to event indexing. label Jul 23, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jul 23, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 23, 2024
@cronokirby cronokirby removed the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 23, 2024
@cronokirby cronokirby mentioned this issue Jul 23, 2024
Closed
13 tasks
@cronokirby cronokirby added this to the Sprint 9 milestone Jul 24, 2024
@cronokirby cronokirby moved this from Backlog to Todo in Penumbra Jul 24, 2024
@cronokirby cronokirby moved this from Todo to In progress in Penumbra Jul 24, 2024
@vacekj vacekj mentioned this issue Jul 25, 2024
Merged
5 tasks
vacekj added a commit that referenced this issue Jul 30, 2024
@vacekj @cronokirby
feat: lp indexing (#4771)
935a17c 
## Describe your changes

implements lp positions and execution indexing

TODO from reviews:
- [x] We want to store the trading pair likely as a new derived type
(tuple) of (BYTEA, BYTEA)
- [x] We definitely need a table storing the current state of any given
position, including permanent information like the trading pair, price,
fees.
- [x] We need to include the reserve amounts in the lp_updates table, to
have a history of the reserves over time.
- [x] Price info, for both updates and current state

## Issue ticket number and link

fixes #4739 

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

indexer-only changes

---------

Co-authored-by: Lucas Meier <[email protected]>
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vacekj vacekj

@cronokirby cronokirby

Labels
A-indexing Area: Relates to event indexing.
Projects
Penumbra
Archived in project
Milestone
Sprint 9
Development

Successfully merging a pull request may close this issue.

feat: lp indexing penumbra-zone/penumbra
2 participants
@vacekj @cronokirby