Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: correctly display denom unit values with round-trip #4802

Open
aubrika opened this issue Aug 12, 2024 · 0 comments
Open

test: correctly display denom unit values with round-trip #4802

aubrika opened this issue Aug 12, 2024 · 0 comments
Labels
A-testing Area: Relates to testing of Penumbra _P-high High priority _P-V2 Priority: after mainnet

Comments

@aubrika
Copy link
Contributor

aubrika commented Aug 12, 2024

This bugfix (linked below) needs a unit test.

It can be triggered by having a Metadata object where the list of units is not sorted. The previous code is incorrect on, for instance, the USDC Metadata currently in the Prax registry. That JSON object could be copied into a unit test, which can create a value like "1.234 USDC", parse it, and check that displaying it round trips (because the correct unit is selected).

Originally posted by @hdevalence in #4801 (comment)

@aubrika aubrika added the _P-V2 Priority: after mainnet label Aug 12, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 12, 2024
@aubrika aubrika added A-testing Area: Relates to testing of Penumbra and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Aug 12, 2024
@aubrika aubrika added this to Penumbra Aug 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Aug 12, 2024
@aubrika aubrika modified the milestones: Sprint 8, Sprint 10 Aug 12, 2024
@aubrika aubrika added the _P-high High priority label Aug 12, 2024
@aubrika aubrika removed this from the Sprint 10 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Area: Relates to testing of Penumbra _P-high High priority _P-V2 Priority: after mainnet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant