Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide withdrawn auction NFTs in pcli view balance #4820

Closed
zbuc opened this issue Aug 15, 2024 · 1 comment
Closed

Hide withdrawn auction NFTs in pcli view balance #4820

zbuc opened this issue Aug 15, 2024 · 1 comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@zbuc
Copy link
Member

zbuc commented Aug 15, 2024

Is your feature request related to a problem? Please describe.
pcli view balance currently filters out withdrawn liquidity positions by default; however, completed/withdrawn auction NFTs are not filtered out and considerably clutter the output.

Describe the solution you'd like
Similarly to LPs, completed/withdrawn auction NFTs should be hidden by default.

@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 15, 2024
zbuc pushed a commit that referenced this issue Aug 23, 2024
…#4826)

## Describe your changes
pcli no longer displays withdrawn auction NFTs when running ```pcli view
balance```

## Issue ticket number and link
#4820 

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason: I have
only modified what pcli filters out before displaying balances and added
a function in denom_metadata that matches a similar function for LPNFTs.

> After completing a number of auctions, viewing my balances through
pcli has become increasingly difficult due to all of my previously
withdrawn auction NFTs. I decided to not filter out closed auction
positions so they can serve as a reminder to withdraw them, matching the
default behavior of the swap frontend.
@zbuc
Copy link
Member Author

zbuc commented Sep 23, 2024

Closed #4826

@zbuc zbuc closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
None yet
Development

No branches or pull requests

1 participant