Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total supply api #4835

Closed
zmanian opened this issue Aug 25, 2024 · 6 comments
Closed

Total supply api #4835

zmanian opened this issue Aug 25, 2024 · 6 comments
Assignees
Labels
A-client Area: Design and implementation for client functionality _P-high High priority
Milestone

Comments

@zmanian
Copy link
Contributor

zmanian commented Aug 25, 2024

To get the Penumbra correctly listed on sites like Coinmarket cap and Coingecko, we need an API that they can query for the total supply of penumbra tokens.

@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 25, 2024
@aubrika
Copy link
Contributor

aubrika commented Aug 26, 2024

We will prioritize this - I scheduled a team design meeting for tomorrow to discuss the best way to implement it.

@aubrika aubrika added A-client Area: Design and implementation for client functionality _P-high High priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Aug 26, 2024
@aubrika aubrika added this to Penumbra Aug 26, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Aug 26, 2024
@aubrika aubrika added this to the Sprint 11 milestone Aug 26, 2024
@zmanian
Copy link
Contributor Author

zmanian commented Aug 26, 2024

Even just an upper bound on the amount penumbra that exists would be sufficient.

@zmanian zmanian closed this as completed Aug 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Penumbra Aug 27, 2024
@zmanian zmanian reopened this Aug 27, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Penumbra Aug 27, 2024
@aubrika aubrika modified the milestones: Sprint 11, Sprint 12 Sep 9, 2024
@hdevalence
Copy link
Member

The computation that needs to be done is:

  • total UM as tracked by the staking component
  • PLUS, for each validator: total delUM for that validator times that validator's exchange rate

This should be very simple to implement, and provide in a new RPC as part of the staking component's QueryService

@cronokirby
Copy link
Contributor

Where does the staking component track total UM?

@aubrika
Copy link
Contributor

aubrika commented Sep 16, 2024

Update following discussion of this internally: a legacy supply tracking implementation was removed from the shielded pool on account of being the wrong place to do this work, but not replaced before launch with another implementation. In the absence of something doing that for us, we will need to utilize our indexer to perform this calculation using historical block data - which is more involved than was initially thought, as it was assumed the protocol was tracking events that it was not. We are actively working on this, just ran into some friction.

@aubrika aubrika modified the milestones: Sprint 12, Sprint 13 Sep 23, 2024
aubrika pushed a commit that referenced this issue Sep 26, 2024
#4835

---------

Co-authored-by: Lucas Meier <[email protected]>
@aubrika
Copy link
Contributor

aubrika commented Oct 7, 2024

This is completed by the total supply indexer work, which can support any number of UI layers

@aubrika aubrika closed this as completed Oct 7, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: Design and implementation for client functionality _P-high High priority
Projects
Archived in project
Development

No branches or pull requests

5 participants