-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app crate doesn't keep component code behind feature flag #4885
Comments
Something this made me think of: what if moved the StateRead / StateWrite traits to another crate ; this would allow a lot of components to just depend on the traits, and not even pull in cnidarium itself |
That could work, but I'm also not sure we'd need to do it, since AFAICT there's not a need to model state access in client code, right? |
This required: - feature gating `cnidarium` in `penumbra-app` - removing the stateless transaction check in the view crate - removing the ceremony contribution command from `pcli` Closes #4885
While working on this, @cronokirby discovered rust-lang/cargo#8157, which describes how feature selection can vary in cargo workspaces. For example:
We've previously been using only the former, but we should probably prefer the latter in most places. |
Describe the bug
Other components keep the state machine part of the code behind a feature flag. The app crate doesn't. This means that any downstream consumer of the rust view server has to pull in and build the entire full node state machine and rocksdb.
The text was updated successfully, but these errors were encountered: