pindexer: repair SQL syntax for create type/create domain #4760
Conversation
| CREATE TYPE Value AS ( | ||
| amount Amount, | ||
| asset BYTEA NOT NULL | ||
| asset BYTEA |
There was a problem hiding this comment.
If the NOT NULL constraint intended here previously is critical, this could be refactored with something like CREATE DOMAIN Asset AS BYTEA NOT NULL; but that might cause translation issues & require a bit more work that this
Not wired up to CI yet, but has proven useful interactively while debugging #4759.
|
This helps, but I'm still seeing errors when I attempt to spin up locally. Running this command should pass, for us to merge this PR: |
|
Much better! The To test, I'm using the STR in #4759. |
|
That did it! 💪 |
|
Drat, I spoke too soon: |
|
That seems to point to a weirder thing in cometindex because that should only happen if you ingest two block root events with the same height |
|
#4762 fixes a bug in cometindex which leads to this |
Yup, testing locally with that fix cherry-picked in resolves, thanks. 👍 |
Fixes some SQL statements in the prior commit which were not valid postgres.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: