Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to monorepo #44

Open
ryuran opened this issue Nov 27, 2019 · 3 comments
Open

Move to monorepo #44

ryuran opened this issue Nov 27, 2019 · 3 comments

Comments

@ryuran
Copy link
Member

ryuran commented Nov 27, 2019

Hello

We should not have dependencies related to ember if a project need only vanilla js config.

To do it properly, "monorepo" can be a way to manage eslint config (as airbnb: https://github.com/airbnb/javascript/tree/master/packages).

You should publish it on NPM with a namespace @peopledoc/eslint-config
Or on github repository now.

@edouard-lopez
Copy link
Contributor

Do you mean to set up a monorepo in order to remove those 2 lines?

"eslint-plugin-ember": "6.x.x",
"eslint-plugin-ember-suave": "1.x.x",

@ryuran
Copy link
Member Author

ryuran commented Jan 10, 2020

Yes, @edouard-lopez I mean 2 packages :

  • base (es native)
  • ember (extending base with plugins and rules dedicated to ember)

And if peopledoc work on an "other" framework :

  • other (extending base with plugins and rules dedicated to other)

@xcambar
Copy link
Contributor

xcambar commented Jan 15, 2020

I'll be happy to read a PR to try the idea. Feel free to open one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants