Log CRC in case of invalid upload for GCS HMAC

boris-ilijic · boris-ilijic · commit e5441de5f61a · 2025-10-09T12:14:13.000+02:00
diff --git a/pbm/storage/gcs/hmac_client.go b/pbm/storage/gcs/hmac_client.go
@@ -97,7 +97,8 @@ func (h hmacClient) save(name string, data io.Reader, options ...storage.Option)
 
 	localCRC := crcToBase64(crc.Sum32())
 	if putInfo.ChecksumCRC32C != localCRC {
-		return errors.Errorf("wrong CRC after uploading %s", name)
+		return errors.Errorf("wrong CRC after uploading %s, GCS: %s, PBM: %s",
+			name, putInfo.ChecksumCRC32C, localCRC)
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,8 @@ func (h hmacClient) save(name string, data io.Reader, options ...storage.Option)`
`97`	`97`
`98`	`98`	`localCRC := crcToBase64(crc.Sum32())`
`99`	`99`	`if putInfo.ChecksumCRC32C != localCRC {`
`100`		`- return errors.Errorf("wrong CRC after uploading %s", name)`
	`100`	`+ return errors.Errorf("wrong CRC after uploading %s, GCS: %s, PBM: %s",`
	`101`	`+ name, putInfo.ChecksumCRC32C, localCRC)`
`101`	`102`	`}`
`102`	`103`
`103`	`104`	`return nil`