Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waveshare2in13v3/waveshare2in13v4: adding v3 and v4 waveshare 2.13" ePaper displays #65

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

x86ed
Copy link

@x86ed x86ed commented Nov 20, 2023

  1. Please prefix the issue title with the primary package affected.
  • creates waveshare2in13v3 with tests and example
  • creates waveshare2in13v4 with tests and example
  1. Mention the issue number it fixes or add the details of the changes if it
    doesn't have a specific issue.
  1. Once integrated, send a PR to https://github.com/periph/cmd to leverage the
    new functionality (if relevant).
  • will update shortly

@x86ed x86ed changed the title waveshare2in13v3/waveshare2in13v4 adding v3 and v4 waveshare 2.13" ePaper displays waveshare2in13v3/waveshare2in13v4: adding v3 and v4 waveshare 2.13" ePaper displays Nov 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: Patch coverage is 68.98955% with 267 lines in your changes missing coverage. Please review.

Project coverage is 50.8%. Comparing base (cfd565d) to head (4d15198).

Files with missing lines Patch % Lines
waveshare2in13v3/waveshare213v3.go 28.9% 89 Missing and 2 partials ⚠️
waveshare2in13v4/waveshare213v4.go 32.7% 74 Missing and 2 partials ⚠️
waveshare2in13v4/errorhandler.go 0.0% 48 Missing ⚠️
waveshare2in13v3/errorhandler.go 0.0% 40 Missing ⚠️
waveshare2in13v3/controller.go 97.7% 1 Missing and 2 partials ⚠️
waveshare2in13v3/drawing.go 97.8% 2 Missing and 1 partial ⚠️
waveshare2in13v4/controller.go 98.1% 1 Missing and 2 partials ⚠️
waveshare2in13v4/drawing.go 97.3% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #65     +/-   ##
=======================================
+ Coverage   49.5%   50.8%   +1.3%     
=======================================
  Files         90      98      +8     
  Lines      11736   12597    +861     
=======================================
+ Hits        5808    6402    +594     
- Misses      5674    5931    +257     
- Partials     254     264     +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benleb
Copy link

benleb commented Dec 4, 2024

v4 works great (v3 not tested, no v3 display...)! thanks!

@maruel
Copy link
Member

maruel commented Dec 7, 2024

I forgot to comment here, can you fix the linter errors? You'll need to rebase.

@x86ed
Copy link
Author

x86ed commented Dec 21, 2024

rerunning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update Waveshare e-Ink display support
4 participants