Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

periph.io/x/devices/v3/bmxx80: add support for filters without using SenseContinuous #74

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

BGodding
Copy link
Contributor

@BGodding BGodding commented Sep 4, 2024

I cannot use the SenseContinuous option with my hardware as there are additional bus contention issues to deal with, but would like to use the built in filtering on the BME sensors.

In order to prevent current implementations from changing their behavior I added a new initialization option to set the standby time. When the Filter and Standby options are set in the device options the sensor will initialize to the normal mode instead of sleep. Additionally when calling Sense mode will not be set to forced if the Filter and Standby options are set as this would prevent the continuous sampling needing for the filtration.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.4%. Comparing base (a9604df) to head (2f31d3e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bmxx80/bmxx80.go 79.2% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #74     +/-   ##
=======================================
+ Coverage   46.0%   46.4%   +0.4%     
=======================================
  Files         82      82             
  Lines       7913   10031   +2118     
=======================================
+ Hits        3642    4654   +1012     
- Misses      4108    5213   +1105     
- Partials     163     164      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maruel
Copy link
Member

maruel commented Sep 4, 2024

Dang gosec got new checks. Let me fix that first, shouldn't take too long.

@maruel
Copy link
Member

maruel commented Sep 4, 2024

I committed 67ec1da to silence the linter.

@maruel maruel merged commit 2cf8fa1 into periph:main Sep 4, 2024
5 of 8 checks passed
@maruel
Copy link
Member

maruel commented Sep 4, 2024

Oh I forgot to mention: thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants