Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete Results not shown when map is in fullscreen #698

Open
Trekky12 opened this issue Jan 1, 2024 · 3 comments · Fixed by #699
Open

Autocomplete Results not shown when map is in fullscreen #698

Trekky12 opened this issue Jan 1, 2024 · 3 comments · Fixed by #699
Labels

Comments

@Trekky12
Copy link

Trekky12 commented Jan 1, 2024

I use Leaflet.fullscreen which uses requestFullscreen on the map container to show the map in a fullscreen mode.
When the map is in fullscreen the autocomplete results are no longer shown because the created Element is not a child of the map container div but a child of the body and therefore not shown.

Is it possible to make the autocomplete results div a child of the map container?

@curtisy1 curtisy1 added the bug label Jan 1, 2024
@curtisy1
Copy link
Collaborator

curtisy1 commented Jan 1, 2024

First things first: Happy New Year!

I agree this would be useful and I'm pretty sure it's not intentional behavior. Would you be okay with having an additional flag to toggle this? I would probably include this as a bug-fix release in v3 at first but that would mean breaking others who depend on the elements not being children of the map.

If that's fine, I'll add a new option to autocomplete in the coming days.

@Trekky12
Copy link
Author

Trekky12 commented Jan 1, 2024

Happy New Year 🎆

thank you very much for your effort! An additional flag would be awesome.
I agree that existing configurations shouldn't break.

@curtisy1
Copy link
Collaborator

curtisy1 commented Jan 6, 2024

I didn't mean to close this immediately. Reopening until I figure out how to properly release a new minor version

@curtisy1 curtisy1 reopened this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants