From d119c1c5c38ce9e19a8af6ef3cad80464f748c85 Mon Sep 17 00:00:00 2001 From: Ro'e Katz Date: Wed, 28 Aug 2024 15:20:25 +0300 Subject: [PATCH 1/2] Data updater tests: Fix cleaning up undefined resource --- packages/opal-client/opal_client/tests/data_updater_test.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/opal-client/opal_client/tests/data_updater_test.py b/packages/opal-client/opal_client/tests/data_updater_test.py index 2b34804d0..f2b27b0fb 100644 --- a/packages/opal-client/opal_client/tests/data_updater_test.py +++ b/packages/opal-client/opal_client/tests/data_updater_test.py @@ -248,6 +248,7 @@ async def test_data_updater_with_report_callback(server): res = await session.get(CHECK_DATA_UPDATE_CALLBACK_URL) current_callback_count = await res.json() + proc2 = None try: proc = multiprocessing.Process(target=trigger_update, daemon=True) proc.start() @@ -283,7 +284,8 @@ async def test_data_updater_with_report_callback(server): finally: await updater.stop() proc.terminate() - proc2.terminate() + if proc2: + proc2.terminate() @pytest.mark.asyncio From 3c7734643379486ae8c97d98f9a72bf39d9ca4d6 Mon Sep 17 00:00:00 2001 From: Ro'e Katz Date: Wed, 28 Aug 2024 17:39:34 +0300 Subject: [PATCH 2/2] Lock fastapi-websocket-rpc to 0.1.25 - as 0.1.26 introduces a regression --- packages/requires.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/requires.txt b/packages/requires.txt index 43f5a740d..d83a946a1 100644 --- a/packages/requires.txt +++ b/packages/requires.txt @@ -2,7 +2,7 @@ idna>=3.3,<4 typer>=0.4.1,<1 fastapi>=0.109.1,<1 fastapi_websocket_pubsub==0.3.7 -fastapi_websocket_rpc>=0.1.21,<1 +fastapi_websocket_rpc==0.1.25 gunicorn>=22.0.0,<23 pydantic[email]>=1.9.1,<2 typing-extensions;python_version<'3.8'