Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sign Up in the Login Flow #17

Open
gemanor opened this issue Oct 28, 2024 · 28 comments
Open

Support Sign Up in the Login Flow #17

gemanor opened this issue Oct 28, 2024 · 28 comments
Assignees
Labels
⚔️ Quest Tracks quest-bot quests

Comments

@gemanor
Copy link
Collaborator

gemanor commented Oct 28, 2024

We want that users without Permit account to be able to create their workspace/project/environment while using the permit login flow.

Acceptance Criteria:

  • User who logged in with the permit login command and do not an account is getting the option to create a new workspace and project
  • e2e test of the flow
@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 28, 2024
Copy link

quest-bot bot commented Oct 28, 2024

New Quest! image New Quest!

A new Quest has been launched in @permitio’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Loot of 150 USD has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #17 to link your PR to this Quest.

Questions? Check out the docs.

@35C4n0r
Copy link
Contributor

35C4n0r commented Oct 28, 2024

@quest-bot embark

Copy link

quest-bot bot commented Oct 28, 2024

@35C4n0r has embarked on their Quest. 🗡

  • @35C4n0r has been on GitHub since 2020.
  • They have merged 0 public PRs in that time.
  • Their swords are blessed with Shell and Python magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@AkashJana18
Copy link

@quest-bot embark

@35C4n0r
Copy link
Contributor

35C4n0r commented Oct 30, 2024

@AkashJana18, I have already started working on this issue :)

@AkashJana18
Copy link

Hey @35C4n0r you are not assigned to the issue so I think I can work on it too
@gemanor can you please confirm ?

@gemanor
Copy link
Collaborator Author

gemanor commented Oct 30, 2024

Hey, @AkashJana18 , We are working on first come first serve for the issues, so I'm assining @35C4n0r for it.

@35C4n0r please share your rough timeline, so we can add it here

@gemanor gemanor self-assigned this Oct 30, 2024
@35C4n0r
Copy link
Contributor

35C4n0r commented Oct 31, 2024

@gemanor, I've started working on this but need feedback from you. I tried the current login flow, but with a new user, it leads to issue with auth0 as we are stuck on /consent (check the loom).
https://www.loom.com/share/ee95fe8d7de04083b1e950447ae9ae0b?from_recorder=1&focus_title=1
I had a discussion with OrWeis and a huddle OdedBD, they suspect this is an OAuth issue, and suggested a different flow for signup via the CLI. Parallely would it be possible to raise a ticket to auth0 mentioning this issue? Maybe we could get a resolution for this. I would have liked to test the signup flow more, maybe try using their SDK, but I've ran out of emails :)

@gemanor
Copy link
Collaborator Author

gemanor commented Nov 3, 2024

@35C4n0r I believe it is related to https://auth0.com/docs/get-started/applications/confidential-and-public-applications/user-consent-and-third-party-applications
Maybe it needs some debugging to understand why the popup is not visible and showing it.

Can you verify if it's redirect you to localhost before handling to consent page?

@Rutik7066
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Nov 4, 2024

@Rutik7066 has embarked on their Quest. 🗡

  • @Rutik7066 has been on GitHub since 2019.
  • They have merged 12 public PRs in that time.
  • Their swords are blessed with Dockerfile and JavaScript magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Copy link

quest-bot bot commented Nov 5, 2024

🧚 @Rutik7066 has submitted PR #27 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @35C4n0r

Questions? Check out the docs.

@the-johnwick
Copy link

@gemanor @35C4n0r Is this issue resolved?

@the-johnwick
Copy link

@gemanor I have found solution. Can you assign this to me?

@gurugubellianil
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Nov 7, 2024

@gurugubellianil has embarked on their Quest. 🗡

  • @gurugubellianil has been on GitHub since 2021.
  • They have merged 0 public PRs in that time.
  • Their swords are blessed with Python and Jupyter Notebook magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@the-johnwick
Copy link

@quest-bot embark

1 similar comment
@coderkhushal
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Nov 9, 2024

@coderkhushal has embarked on their Quest. 🗡

  • @coderkhushal has been on GitHub since 2023.
  • They have merged 0 public PRs in that time.
  • Their swords are blessed with TypeScript and Dockerfile magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@vishwamartur
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Nov 15, 2024

@vishwamartur has embarked on their Quest. 🗡

  • @vishwamartur has been on GitHub since 2020.
  • They have merged 0 public PRs in that time.
  • Their swords are blessed with HTML and CSS magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

vishwamartur added a commit to vishwamartur/permit-cli that referenced this issue Nov 15, 2024
Related to permitio#17

Add support for user sign-up in the `permit login` flow.

* **Login Flow Enhancements**
  - Add logic in `source/commands/login.tsx` to handle new user sign-ups and account creation during the login process.
  - Prompt users without an account to create a new workspace and project if none are found.
  - Update the state management to include the new sign-up flow.
  - Add API calls to create new workspace and project.

* **End-to-End Tests**
  - Add e2e tests in `test.tsx` to cover the new sign-up flow.
  - Ensure proper functionality of the new sign-up flow.
Copy link

quest-bot bot commented Nov 15, 2024

🧚 @vishwamartur has submitted PR #32 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @gurugubellianil
@Rutik7066
@35C4n0r
@coderkhushal

Questions? Check out the docs.

@gemanor
Copy link
Collaborator Author

gemanor commented Nov 24, 2024

Hey, @the-johnwick / @35C4n0r / @Rutik7066 has any of you found a solution for the consent issue? Want to share?

@gemanor gemanor removed their assignment Nov 24, 2024
@Rutik7066
Copy link

Rutik7066 commented Nov 25, 2024

Hey, @the-johnwick / @35C4n0r / @Rutik7066 has any of you found a solution for the consent issue? Want to share?

@gemanor Check out my closed PR. I am travelling so I won't be able to make video. I have implemented the solution in the PR. Let me know If still issue persists.

@gemanor
Copy link
Collaborator Author

gemanor commented Nov 29, 2024

@Rutik7066 The PR should comply with the existing PR by @35C4n0r
Let me know when you have time to look on it

@Rutik7066
Copy link

@gemanor Please test it once on your side. If everything works with current approach I will update the PR on @35C4n0r's PR. My all gmail account has been utilised already. While working on it.

@gemanor
Copy link
Collaborator Author

gemanor commented Dec 13, 2024

I'm assigning @35C4n0r as first come first serve here

Copy link

quest-bot bot commented Dec 29, 2024

🧚 @35C4n0r has submitted PR #56 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @gurugubellianil
@Rutik7066
@vishwamartur
@coderkhushal

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

No branches or pull requests

8 participants