Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the AuthProvider functionality #52

Open
gemanor opened this issue Dec 15, 2024 · 18 comments · May be fixed by #53
Open

Improve the AuthProvider functionality #52

gemanor opened this issue Dec 15, 2024 · 18 comments · May be fixed by #53
Assignees
Labels
⚔️ Quest Tracks quest-bot quests

Comments

@gemanor
Copy link
Collaborator

gemanor commented Dec 15, 2024

The purpose of the issue is to give developers a unified way to log in to Permit. To do that, the following improvements are needed in the existing AuthProvider command.

  1. Mandatory key component. If the key is provided, the provider will perform validation of the key
  2. If the key is not provided, the provider will take the key from the keychain and perform a browser login if it does not exist
  3. Add an optional scope component - if provided:
    1. In case no key is provided and the scope is higher than project, - init the browser auth
    2. In case key is provided, validate that the API key is valid to the scope

This issue is about to get assigned to @35C4n0r

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Dec 15, 2024
Copy link

quest-bot bot commented Dec 15, 2024

New Quest! image New Quest!

A new Quest has been launched in @permitio’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Loot of 150 USD has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #52 to link your PR to this Quest.

Questions? Check out the docs.

@35C4n0r
Copy link
Contributor

35C4n0r commented Dec 15, 2024

@quest-bot embark

Copy link

quest-bot bot commented Dec 15, 2024

@35C4n0r has embarked on their Quest. 🗡

  • @35C4n0r has been on GitHub since 2020.
  • They have merged 87 public PRs in that time.
  • Their swords are blessed with Shell and Dockerfile magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@azar-writes-code
Copy link

Hi @gemanor ,
If @35C4n0r failed to finish this task, can you assign this to me? looking forward to work :)
TIA

@azar-writes-code
Copy link

@35C4n0r Bro, any updates on this?

@azar-writes-code
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Dec 16, 2024

@azar-writes-code has embarked on their Quest. 🗡

  • @azar-writes-code has been on GitHub since 2018.
  • They have merged 23 public PRs in that time.
  • Their swords are blessed with Dockerfile and JavaScript magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@35C4n0r 35C4n0r linked a pull request Dec 16, 2024 that will close this issue
Copy link

quest-bot bot commented Dec 16, 2024

🧚 @35C4n0r has submitted PR #53 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @azar-writes-code

Questions? Check out the docs.

@n-sipho
Copy link

n-sipho commented Dec 23, 2024

@quest-bot embark

Copy link

quest-bot bot commented Dec 23, 2024

@n-sipho has embarked on their Quest. 🗡

  • @n-sipho has been on GitHub since 2019.
  • They have merged 46 public PRs in that time.
  • Their swords are blessed with JavaScript and CSS magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@SxxAq
Copy link

SxxAq commented Dec 23, 2024

@quest-bot embark

Copy link

quest-bot bot commented Dec 23, 2024

@SxxAq has embarked on their Quest. 🗡

  • @SxxAq has been on GitHub since 2022.
  • They have merged 29 public PRs in that time.
  • Their swords are blessed with JavaScript and CSS magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@shivvamm
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Dec 30, 2024

@shivvamm has embarked on their Quest. 🗡

  • @shivvamm has been on GitHub since 2019.
  • They have merged 12 public PRs in that time.
  • Their swords are blessed with JavaScript and HTML magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@naaa760
Copy link

naaa760 commented Dec 30, 2024

@quest-bot embark

Copy link

quest-bot bot commented Dec 30, 2024

@naaa760 has embarked on their Quest. 🗡

  • @naaa760 has been on GitHub since 2024.
  • They have merged 4 public PRs in that time.
  • Their swords are blessed with JavaScript and TypeScript magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@Suyash878
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Dec 30, 2024

@Suyash878 has embarked on their Quest. 🗡

  • @Suyash878 has been on GitHub since 2023.
  • They have merged 15 public PRs in that time.
  • Their swords are blessed with JavaScript and CSS magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants