Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You guys seriously need to improve browser integration #29

Open
Witchilich opened this issue Nov 22, 2019 · 5 comments
Open

You guys seriously need to improve browser integration #29

Witchilich opened this issue Nov 22, 2019 · 5 comments

Comments

@Witchilich
Copy link

Witchilich commented Nov 22, 2019

System Details:

  • Operating System: Windows 10

  • Persepolis Version: 3.2.0.0

  • How do you install Persepolis? Scoop

  • Please attach log files if crash or paste error message

Issue Description and steps to reproduce:

Write in English language please, Thanks :)

Feel free to edit or delete lines in this template if it is necessary.

Please report only one Issue (Bug or feature request or ...) in one issue! and open new Issue for another one :)

This download manager has everything going for it except for the browser integration on Windows. It wont start at all if Persepolis is not running in the background.

This is one thing that needs improvement. I want it to capture my download immediately and always.

@alireza-amirsamimi alireza-amirsamimi transferred this issue from persepolisdm/persepolis Nov 24, 2019
@Witchilich
Copy link
Author

Witchilich commented Nov 28, 2019

And I found this

Known bugs:
Firefox in MS Windows can't open Persepolis. Persepolis must be executed manually by user.

I have this problem in both Firefox and and Chromium Edge(using the Chrome Extension). I need to manually start Persepolis for it to interrupt downloads.

@7aman
Copy link

7aman commented Nov 28, 2019

@restia666ashdoll
Hi. I made some changes before to solve this. It is one month behind latest commits. But it works. You can test it by installing from this repo. (only x64)
https://github.com/7aman/pdm-win-build/releases

@Witchilich
Copy link
Author

Witchilich commented Nov 28, 2019

This works like a charm on Edge Chromium(for some reason it didnt work). On Firefox I have to right click and select 'Download with Persepolis', then again I dont really use download manager on firefox by default.
Will these changes make their way to official release ?

@7aman
Copy link

7aman commented Nov 28, 2019

There is no clear way to make an editable installation of persepolis in windows. So there are a few developers interested to work on windows related issues of persepolis.
I am interested but I could not spend more time to improve my code. My PR still is in review and not accepted.

@alireza-amirsamimi
Copy link
Member

@7aman Hello
I am a little busy. Thanks for your pull request. I'll improve your PR and I'll accept the PR very soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants