fix: add validator cap and bond checks when creating the delegation strategy #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kruspy
commented
Apr 8, 2024
puneet2019
reviewed
Apr 9, 2024
puneet2019
reviewed
Apr 9, 2024
x/liquidstake/keeper/liquidstake.go
Outdated
|
|
||
| // just delegate if the validator does not exceed any of the validator specific caps | ||
| if !k.stakingKeeper.CheckExceedsValidatorBondCap(ctx, validator, outputShares) && | ||
| !k.stakingKeeper.CheckExceedsValidatorLiquidStakingCap(ctx, validator, outputShares, false) { |
There was a problem hiding this comment.
here if it still has some space, we should try to fill everything up
|
I've done a rework on the function and modified the LiquidStake one as well. The previous version was wrong. You'll also see I've removed a few test parts that were checking exact delegations since the delegation strategy uses a map and it is not possible to have consistent results when testing. Still, the overall amounts are checked. |
puneet2019
requested changes
Apr 9, 2024
| if leftOver.LT(numValidators) { // if the leftover is less than the number of validators to be delegated, just add it to the first one that can receive it | ||
| diffPerValidator = leftOver | ||
| } | ||
| for strAddr := range delegations { |
There was a problem hiding this comment.
this is a ticking bomb for non determinism. do not iterate over maps. both here and https://github.com/persistenceOne/pstake-native/pull/810/files#diff-d71073dfa714aa345a7e072ed4d0626328925c093d70acb85254b12df28eb45dR562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.