Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests? #78

Closed
ejhumphrey opened this issue Apr 3, 2017 · 2 comments
Closed

Refactoring tests? #78

ejhumphrey opened this issue Apr 3, 2017 · 2 comments

Comments

@ejhumphrey
Copy link
Collaborator

kay, last issue of the day before actually doing something 😄

I would like to indulge my OCD and refactor the tests directory to take a {name}.py -> test_{name}.py structure. By that paradigm, we're currently missing test_core.py and test_buffered.py... it's all getting tested, since our coverage is ≈97%, but I'm finding it less than obvious how / where to dive in and start making changes.

what say you @cjacoby @bmcfee?

@cjacoby
Copy link
Collaborator

cjacoby commented Apr 3, 2017

I am not offended by this, go for it as far as I'm concerned.

I have two bonus thoughts about this (these are on principle, requiring no actual changes to your proposals... yet)

  1. I agree in general about {name}.py -> test_{name}.py, with the following modifications:

    • Due to the py.test inability to handle multiple test files with the same name, I usually do:
      {submodule}/{name}.py => test_{submodule}_{name}.py
      although that doesn't matter to us yet. (But would on your transforms proposal)
  2. To me Integration/system tests or the like also don't necessarily follow this convention.

@ejhumphrey
Copy link
Collaborator Author

closed with #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants