Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PasswordPolicy for password expiration period #326

Closed
henry0715-dev opened this issue Aug 19, 2024 · 3 comments
Closed

Introduce PasswordPolicy for password expiration period #326

henry0715-dev opened this issue Aug 19, 2024 · 3 comments

Comments

@henry0715-dev
Copy link
Contributor

henry0715-dev commented Aug 19, 2024

Pre-work is required in "Review-Database" to add password-related logic in "Review-WEB".
The account policy to be added is as follows: b"password expiration period".

expiry_period_in_secs This seems to be being used as a value for the expiration of the login session.
I need to save a different value so that you can check the password expiration date.

We need to implement CRUD functionality for the value of "password expiration period." To achieve this, it is necessary to determine whether to add a new field to the AccountPolicy or to declare a separate structure for this purpose.

  1. Adding a new field: Modify all the functions that are currently in use.
#[derive(Serialize, Deserialize)]
pub struct AccountPolicy {
    pub(crate) expiry_period_in_secs: u32,
    pub(crate) expiry_password_period_in_days: u32,
}
  1. Adding a new structure
#[derive(Serialize, Deserialize)]
pub struct PasswordPolicy {
    pub(crate) expiry_password_period_in_days: u32,
}

I would like to ask for your opinion on which approach, between option 1 and option 2, would be preferable for implementation. Henry is scheduled to carry out this task.

reference
aicers/review-web#41
aicers/review-web#42

@henry0715-dev
Copy link
Contributor Author

henry0715-dev commented Aug 28, 2024

I'll work with option 2.

@sophie-cluml
Copy link
Contributor

I think aicers/review-web#41 suggests option 2, and I agree with your choice.

@sehkone sehkone changed the title Add Account Policy for password expiration period Add password expiration period to AccountPolicy Aug 28, 2024
@sehkone sehkone changed the title Add password expiration period to AccountPolicy Introduce PasswordPolicy for password expiration period Aug 28, 2024
henry0715-dev added a commit to henry0715-dev/review-database that referenced this issue Aug 28, 2024
@henry0715-dev
Copy link
Contributor Author

We plan to proceed after the #100 issue is processed, so we will close the current issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants