Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in pull requests #6

Open
fschlaef opened this issue Aug 6, 2024 · 1 comment
Open

Interest in pull requests #6

fschlaef opened this issue Aug 6, 2024 · 1 comment

Comments

@fschlaef
Copy link

fschlaef commented Aug 6, 2024

Hi there,

I'm still using this project for my small LED light at home. I've deployed the async fork found here #4 and modified it. I'm wondering if you would be interested in any PR.

What I did and what I have in mind :

  • Replace uWeb with tinyweb for async functionality, which @griffhurt did (uWeb seems no longer maintained)
  • Fix bugs, such as Rainbow Chase animation indexes the array out of bounds #5
  • Make all animations infinite by default (remove the Cycles option in Rainbow for example)
  • Add a default animation on startup (after the startup animation)
  • Update the UI to fix some bugs (I've noticed an issue with the slider)
  • Update frontend dependencies
  • Make the animations take the brightness value into account (currently only applied to static colors)
  • Improve animations & add new ones as needed
  • Edit: Add a config file and bootstrapper

Let me know if you're interested, I'd be happy to contribute !

@petabite
Copy link
Owner

petabite commented Aug 7, 2024

Hi! Yes, absolutely! Contributions are very much welcome. Those changes sound awesome. I'd be more than happy to take a look at a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants